From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 903E1A04B1; Mon, 5 Oct 2020 21:34:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C68524C93; Mon, 5 Oct 2020 21:34:07 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by dpdk.org (Postfix) with ESMTP id 485C12952 for ; Mon, 5 Oct 2020 21:34:06 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1059) id 9289C20BE4A6; Mon, 5 Oct 2020 12:34:04 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9289C20BE4A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1601926444; bh=bj2nnZZbIl0ZjOdls5Vkrek7SDp+XDVjUlVD6eJc0mo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LdE6Sy2+WoXaHn4N//B8YElRiONoPlAcDjXgLouWrIPq3W/Y7yaKf4YUiYF/Ph0m6 Pa2xkUQjyY4bIq5anSmmh+R3IKp500q4H7ED+qHM9Hy+tcG+WV6dChymxM+s2gyLlP 9BNbZCWiso+UcU+54ksoZZ7yv50hONNmVxo462PU= Date: Mon, 5 Oct 2020 12:34:04 -0700 From: Narcisa Ana Maria Vasile To: Ranjit Menon Cc: dev@dpdk.org, thomas@monjalon.net, ocardona@microsoft.com, haramakr@linux.microsoft.com, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, dmitrym@microsoft.com, Narcisa Vasile , Harini Ramakrishnan Message-ID: <20201005193404.GA4932@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1600483953-28579-1-git-send-email-navasile@linux.microsoft.com> <1601592908-11262-1-git-send-email-navasile@linux.microsoft.com> <7f5f4978-f967-66e8-5152-5446198bfd42@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f5f4978-f967-66e8-5152-5446198bfd42@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v5] windows/netuio: add Windows NetUIO kernel driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 02, 2020 at 11:21:54AM -0700, Ranjit Menon wrote: > > On 10/1/2020 3:55 PM, Narcisa Ana Maria Vasile wrote: > >From: Narcisa Vasile > > > >The Windows netuio kernel driver provides the DPDK userspace application > >with direct access to hardware, by mapping the HW registers in userspace > >and allowing read/write operations from/to the device > >configuration space. > > > >Two IOCTLs are defined by the netuio interface: > > * IOCTL_NETUIO_MAP_HW_INTO_USERSPACE > > - used for mapping the device registers into userspace > > * IOCTL_NETUIO_PCI_CONFIG_IO > > - used to read/write from/into the device configuration space > > > >Note: > >Requests to map the device BARs into userspace need to be processed > >in the thread context of the process that initiated the mapping request. > >Otherwise, the BARs might end up mapped into an arbitrary process > >address space. > >EvtIoInCallerContext is used to ensure the requests are handled > >in the right user thread context. Other requests (PCI config) > >are sent back to the framework and processed by the EvtIoDeviceControl > >callback. > > > >Cc: Harini Ramakrishnan > >Cc: Omar Cardona > >Cc: Dmitry Malloy > >Signed-off-by: Narcisa Vasile > >--- > > > > We'll need to do a code-style cleanup at some point, but for now: > Yes, agreed. I'll send a patch for style cleanup after merging this one. Thanks, Ranjit. > Reviewed-by: Ranjit Menon > > Acked-by: Ranjit Menon