From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E28CA04BB; Tue, 6 Oct 2020 09:08:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58379F64; Tue, 6 Oct 2020 09:08:23 +0200 (CEST) Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id B32C5F3E for ; Tue, 6 Oct 2020 09:08:21 +0200 (CEST) Received: from glumotte.dev.6wind.com. (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 75AE446B205; Tue, 6 Oct 2020 09:08:20 +0200 (CEST) From: Olivier Matz To: dev@dpdk.org Cc: Andrew Rybchenko , Ray Kinsella , Neil Horman Date: Tue, 6 Oct 2020 09:07:49 +0200 Message-Id: <20201006070750.27104-1-olivier.matz@6wind.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/2] mempool: remove v20 ABI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove the deprecated v20 ABI of rte_mempool_populate_iova() and rte_mempool_populate_virt(). Signed-off-by: Olivier Matz --- lib/librte_mempool/meson.build | 2 - lib/librte_mempool/rte_mempool.c | 79 ++-------------------- lib/librte_mempool/rte_mempool_version.map | 7 -- 3 files changed, 5 insertions(+), 83 deletions(-) diff --git a/lib/librte_mempool/meson.build b/lib/librte_mempool/meson.build index 7dbe6b9bea..a6e861cbfc 100644 --- a/lib/librte_mempool/meson.build +++ b/lib/librte_mempool/meson.build @@ -9,8 +9,6 @@ foreach flag: extra_flags endif endforeach -use_function_versioning = true - sources = files('rte_mempool.c', 'rte_mempool_ops.c', 'rte_mempool_ops_default.c', 'mempool_trace_points.c') headers = files('rte_mempool.h', 'rte_mempool_trace.h', diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 7774f0c8da..0e3a2a7635 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -30,7 +30,6 @@ #include #include #include -#include #include @@ -305,17 +304,12 @@ mempool_ops_alloc_once(struct rte_mempool *mp) return 0; } -__vsym int -rte_mempool_populate_iova_v21(struct rte_mempool *mp, char *vaddr, - rte_iova_t iova, size_t len, rte_mempool_memchunk_free_cb_t *free_cb, - void *opaque); - /* Add objects in the pool, using a physically contiguous memory * zone. Return the number of objects added, or a negative value * on error. */ -__vsym int -rte_mempool_populate_iova_v21(struct rte_mempool *mp, char *vaddr, +int +rte_mempool_populate_iova(struct rte_mempool *mp, char *vaddr, rte_iova_t iova, size_t len, rte_mempool_memchunk_free_cb_t *free_cb, void *opaque) { @@ -375,35 +369,6 @@ rte_mempool_populate_iova_v21(struct rte_mempool *mp, char *vaddr, return ret; } -BIND_DEFAULT_SYMBOL(rte_mempool_populate_iova, _v21, 21); -MAP_STATIC_SYMBOL( - int rte_mempool_populate_iova(struct rte_mempool *mp, char *vaddr, - rte_iova_t iova, size_t len, - rte_mempool_memchunk_free_cb_t *free_cb, - void *opaque), - rte_mempool_populate_iova_v21); - -__vsym int -rte_mempool_populate_iova_v20(struct rte_mempool *mp, char *vaddr, - rte_iova_t iova, size_t len, rte_mempool_memchunk_free_cb_t *free_cb, - void *opaque); - -__vsym int -rte_mempool_populate_iova_v20(struct rte_mempool *mp, char *vaddr, - rte_iova_t iova, size_t len, rte_mempool_memchunk_free_cb_t *free_cb, - void *opaque) -{ - int ret; - - ret = rte_mempool_populate_iova_v21(mp, vaddr, iova, len, free_cb, - opaque); - if (ret == 0) - ret = -EINVAL; - - return ret; -} -VERSION_SYMBOL(rte_mempool_populate_iova, _v20, 20.0); - static rte_iova_t get_iova(void *addr) { @@ -417,16 +382,11 @@ get_iova(void *addr) return ms->iova + RTE_PTR_DIFF(addr, ms->addr); } -__vsym int -rte_mempool_populate_virt_v21(struct rte_mempool *mp, char *addr, - size_t len, size_t pg_sz, rte_mempool_memchunk_free_cb_t *free_cb, - void *opaque); - /* Populate the mempool with a virtual area. Return the number of * objects added, or a negative value on error. */ -__vsym int -rte_mempool_populate_virt_v21(struct rte_mempool *mp, char *addr, +int +rte_mempool_populate_virt(struct rte_mempool *mp, char *addr, size_t len, size_t pg_sz, rte_mempool_memchunk_free_cb_t *free_cb, void *opaque) { @@ -459,7 +419,7 @@ rte_mempool_populate_virt_v21(struct rte_mempool *mp, char *addr, break; } - ret = rte_mempool_populate_iova_v21(mp, addr + off, iova, + ret = rte_mempool_populate_iova(mp, addr + off, iova, phys_len, free_cb, opaque); if (ret == 0) continue; @@ -477,35 +437,6 @@ rte_mempool_populate_virt_v21(struct rte_mempool *mp, char *addr, rte_mempool_free_memchunks(mp); return ret; } -BIND_DEFAULT_SYMBOL(rte_mempool_populate_virt, _v21, 21); -MAP_STATIC_SYMBOL( - int rte_mempool_populate_virt(struct rte_mempool *mp, - char *addr, size_t len, size_t pg_sz, - rte_mempool_memchunk_free_cb_t *free_cb, - void *opaque), - rte_mempool_populate_virt_v21); - -__vsym int -rte_mempool_populate_virt_v20(struct rte_mempool *mp, char *addr, - size_t len, size_t pg_sz, rte_mempool_memchunk_free_cb_t *free_cb, - void *opaque); - -__vsym int -rte_mempool_populate_virt_v20(struct rte_mempool *mp, char *addr, - size_t len, size_t pg_sz, rte_mempool_memchunk_free_cb_t *free_cb, - void *opaque) -{ - int ret; - - ret = rte_mempool_populate_virt_v21(mp, addr, len, pg_sz, - free_cb, opaque); - - if (ret == 0) - ret = -EINVAL; - - return ret; -} -VERSION_SYMBOL(rte_mempool_populate_virt, _v20, 20.0); /* Get the minimal page size used in a mempool before populating it. */ int diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map index 50e22ee020..83760ecfc9 100644 --- a/lib/librte_mempool/rte_mempool_version.map +++ b/lib/librte_mempool/rte_mempool_version.map @@ -31,13 +31,6 @@ DPDK_21 { local: *; }; -DPDK_20.0 { - global: - - rte_mempool_populate_iova; - rte_mempool_populate_virt; -}; - EXPERIMENTAL { global: -- 2.25.1