From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB8B6A04BB; Tue, 6 Oct 2020 12:09:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 29AD22952; Tue, 6 Oct 2020 12:09:05 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id CF59FF64 for ; Tue, 6 Oct 2020 12:09:03 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id j136so2450948wmj.2 for ; Tue, 06 Oct 2020 03:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qW/v4plxNHifrDVULS1J0IZ0Rx0mLN/PZUsQFEgyRbk=; b=WJyhOEQ6wHevpICIRuF/D3lBdUG/M+iQbk47F+YV+oMf3uoUYb7+wMFydFSzvrFQjc GXRCx55lhxl4mD3SisV4DpJCdOzp/w0N8IXvcq8679rN84iq+9juSogtbMdP/qsrZCne /VWcF6AD2vWSaE4SKTKcj52MaZOGQtuETQ+26sPtR7LqhTeUEdZvTiOGy+nWRpWiertz 3gbIgHn2yGTWYJVJjKuveZzFn+NiIl3UI5Xgsvl0UONblAHdy3+iB6N3P9jCCFBYHClT vuqLVXIlfEGbha2quUh2eLjOILOv8+2rQ3MKw0c3wM8CtQyH6xoNEnnKNYST0y9G52XX DxOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qW/v4plxNHifrDVULS1J0IZ0Rx0mLN/PZUsQFEgyRbk=; b=pNVM5ClKk5+d9tnZXWCizqeSwUoa/RSO8bVw6Pw9iSVtBOf9rn6+KNx6dhNC0+g44M jumlK2H2TO6BNGazHmFo9CmfyT0TGlp5lrcDyNFicamuIg/jeN9VDtBAHrApANFTrXoM 9d4dOaIPMseeiWQv4Bn+j61SxeECJJauzC27KKBrpCANu9DDrH8FfGxjQy8RJFLKoWCW 0X+rJPbgUnREDem/6MRDqtf6G4G0cUasmKyLSJjZ22LUGCL/1Oix2pZfNTjjmnsKPipI SZdM8Zq2NdoGMM12CJZyG15+i0fuBpktf59lSRplRwIxZXj/IxMnCoAlCaXZmdqjuiHW XxFg== X-Gm-Message-State: AOAM532yc1GBSoc0e5Ms8UUmiz/fpImHKWaladTj40NoQE5klRm3r+Vr GoWOzUJ1ku/6yFQubzwzPo+m28m0CmVARPIs X-Google-Smtp-Source: ABdhPJx2QwYLRU8z0WddQGGY9MJMrDKuAY/MxeBNnylSCwVwHtbcspGOdb4svYyI0n9FzUUfg3BqLQ== X-Received: by 2002:a7b:c7c9:: with SMTP id z9mr3919323wmk.136.1601978942578; Tue, 06 Oct 2020 03:09:02 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id f14sm3934388wrt.53.2020.10.06.03.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 03:09:01 -0700 (PDT) Date: Tue, 6 Oct 2020 12:09:01 +0200 From: Olivier Matz To: "Zhang, Roy Fan" Cc: "dev@dpdk.org" , "Kovacevic, Marko" , Akhil Goyal , "Kusztal, ArkadiuszX" , "stable@dpdk.org" , Anoob Joseph Message-ID: <20201006100901.GJ21395@platinum> References: <20201006074143.31691-1-olivier.matz@6wind.com> <20201006074143.31691-3-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 2/3] examples/fips_validation: ignore \r in input files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: Hi Fan, On Tue, Oct 06, 2020 at 08:47:10AM +0000, Zhang, Roy Fan wrote: > Hi Olivier, > > > -----Original Message----- > > From: Olivier Matz > > Sent: Tuesday, October 6, 2020 8:42 AM > > To: dev@dpdk.org > > Cc: Kovacevic, Marko ; Akhil Goyal > > ; Zhang, Roy Fan ; Kusztal, > > ArkadiuszX ; stable@dpdk.org > > Subject: [PATCH 2/3] examples/fips_validation: ignore \r in input files > > > > Some test vectors contain '\r' before '\n' (see link). Ignore them. > > > > Link: https://www.openssl.org/docs/fips/testvectors-linux-2007-10-10.tar.gz > > Fixes: 3d0fad56b74a ("examples/fips_validation: add crypto FIPS application") > > Cc: stable@dpdk.org > > > > Signed-off-by: Olivier Matz > > --- > > examples/fips_validation/fips_validation.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/examples/fips_validation/fips_validation.c > > b/examples/fips_validation/fips_validation.c > > index 13f763c9aa..858f581ba3 100644 > > --- a/examples/fips_validation/fips_validation.c > > +++ b/examples/fips_validation/fips_validation.c > > @@ -33,6 +33,8 @@ get_file_line(void) > > > > if (loc >= MAX_LINE_CHAR - 1) > > return -ENOMEM; > > + if (c == '\r') > > + continue; > > if (c == '\n') > > break; > > line[loc++] = c; > > -- > > > The patch looks ok but the test file link you provided in the patch is CAVS > 5.3. > > As mentioned in > https://doc.dpdk.org/guides/sample_app_ug/fips_validation.html, the supported > CAVS supported version is 21.0 (not latest one by newer than 5.3). In CAVS > 21.0 test files there is no '\r' before '\n' (I suppose this is for Windows > right). Thank you for your feedback. I'm ok to drop this patch from the patchset if you feel it's useless, or I can update the commit log with the information you provide, to clarify that it should not happen with the supported version of CAVS. Please let me know what you prefer. Thanks, Olivier