From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C32F1A04BB; Tue, 6 Oct 2020 13:41:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D84294C8E; Tue, 6 Oct 2020 13:40:30 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DBF371C01; Tue, 6 Oct 2020 13:40:27 +0200 (CEST) IronPort-SDR: xJVDJmGl03lQHFs3jxqu/VNKr6+j7m+aL0zy0OBmiHhbKtZRFy/ESni5F09aBa1z8dMnKM6aAa cW4nSi1NOi+A== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="151385697" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="151385697" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 04:40:25 -0700 IronPort-SDR: A/oeiccyL20Zw7/qGtE8wwzCGO8r6uOlYKB0KtfA0uwB2x2Q2QWfzvogewGmxwGHr1k/edA4Yk v/1nqAIEe//w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="354335055" Received: from silpixa00400352.ir.intel.com ([10.237.213.132]) by orsmga007.jf.intel.com with ESMTP; 06 Oct 2020 04:40:24 -0700 From: David Coyle To: pablo.de.lara.guarch@intel.com, declan.doherty@intel.com Cc: dev@dpdk.org, akhil.goyal@nxp.com, David Coyle , stable@dpdk.org Date: Tue, 6 Oct 2020 12:40:21 +0100 Message-Id: <20201006114021.1716-1-david.coyle@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201006094215.49882-1-david.coyle@intel.com> References: <20201006094215.49882-1-david.coyle@intel.com> Subject: [dpdk-dev] [PATCH v2] crypto/aesni_mb: fix incorrect clearing of security session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object. This patch fixes this issue by now clearing the private session object. Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") Cc: stable@dpdk.org Signed-off-by: David Coyle Acked-by: Pablo de Lara --- v2: * CC'ing stable@dpdk.org drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c index 2362f0c3c..b11d7f12b 100644 --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c @@ -911,7 +911,7 @@ aesni_mb_pmd_sec_sess_destroy(void *dev __rte_unused, if (sess_priv) { struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv); - memset(sess, 0, sizeof(struct aesni_mb_session)); + memset(sess_priv, 0, sizeof(struct aesni_mb_session)); set_sec_session_private_data(sess, NULL); rte_mempool_put(sess_mp, sess_priv); } -- 2.17.1