From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E01FA04BC; Thu, 8 Oct 2020 13:34:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A22B1BDB3; Thu, 8 Oct 2020 13:34:33 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 00D331BD82; Thu, 8 Oct 2020 13:34:29 +0200 (CEST) IronPort-SDR: gq3FKCflHtHbikd9mwYM0kwCmDv4JrSHq+xDK2XZtLB3QBQ4JwEsuODp0pxSja66hJVI5T+mzp GnDs2E14g2wQ== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="226966394" X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="226966394" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 04:34:28 -0700 IronPort-SDR: rVQUfAX2kHr3bHdwaZF9urou1Cfut+ZJwed1o1c9EHp01GtK1z3tJUujudep3r2TEmmsyx2WQZ WBSrAFbN0P5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="461785247" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 08 Oct 2020 04:34:27 -0700 From: Ferruh Yigit To: Ferruh Yigit , Aideen McLoughlin Cc: dev@dpdk.org, stable@dpdk.org, Muthurajan Jayakumar Date: Thu, 8 Oct 2020 12:34:25 +0100 Message-Id: <20201008113425.241010-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/pcap: fix input only Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When input only Rx interface argument 'rx_iface_in' provided, current code assigns 'eth_null_rx' burst function by mistake and no packet received as a result. Like in following usage no packets received from physical interface: "--vdev net_pcap0,rx_iface_in=eth0,tx_iface=eth0" Fixing the burst function assignment when 'rx_iface_in' argument is used Fixes: f14a94591504 ("net/pcap: remove Rx queue argument necessity") Cc: stable@dpdk.org Reported-by: Muthurajan Jayakumar Signed-off-by: Ferruh Yigit --- Cc: aideen.mcloughlin@intel.com --- drivers/net/pcap/rte_eth_pcap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index da4988064a..057aa9dbfc 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -1416,7 +1416,8 @@ pmd_pcap_probe(struct rte_vdev_device *dev) devargs_all.is_rx_pcap = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG) ? 1 : 0; devargs_all.is_rx_iface = - rte_kvargs_count(kvlist, ETH_PCAP_RX_IFACE_ARG) ? 1 : 0; + (rte_kvargs_count(kvlist, ETH_PCAP_RX_IFACE_ARG) + + rte_kvargs_count(kvlist, ETH_PCAP_RX_IFACE_IN_ARG)) ? 1 : 0; pcaps.num_of_queue = 0; devargs_all.is_tx_pcap = -- 2.26.2