From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: bluca@debian.org
Subject: Re: [dpdk-dev] [RFC PATCH] build: use libpcap only from pkg-config
Date: Thu, 8 Oct 2020 18:08:05 +0100 [thread overview]
Message-ID: <20201008170805.GF1106@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201008170536.124111-1-bruce.richardson@intel.com>
On Thu, Oct 08, 2020 at 06:05:36PM +0100, Bruce Richardson wrote:
> All recent linux distro's - including RHEL 8 and Ubuntu 18.04 - provide a
> pkg-config file for libpcap, and using other methods of finding the library
> can cause issues when cross-compiling, so we can limit build support for
> pcap versions without a .pc file.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> config/meson.build | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/config/meson.build b/config/meson.build
> index 69f2aeb60..edc6c195a 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -163,13 +163,7 @@ if libbsd.found()
> endif
>
> # check for pcap
> -pcap_dep = dependency('pcap', required: false)
> -if pcap_dep.found()
> - # pcap got a pkg-config file only in 1.9.0 and before that meson uses
> - # an internal pcap-config finder, which is not compatible with
> - # cross-compilation, so try to fallback to find_library
> - pcap_dep = cc.find_library('pcap', required: false)
> -endif
> +pcap_dep = dependency('libpcap', required: false, method: 'pkg-config')
> if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)
> dpdk_conf.set('RTE_PORT_PCAP', 1)
> dpdk_extra_ldflags += '-lpcap'
Just sending this as an RFC for consideration, since I hit problems with
the pcap code when testing 32-bit (x32) builds, and remembered having hit
it previously too.
Does anyone see an issue with limiting our pcap detection to pkg-config
only in this case?
/Bruce
next prev parent reply other threads:[~2020-10-08 17:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 17:05 Bruce Richardson
2020-10-08 17:08 ` Bruce Richardson [this message]
2020-10-09 9:09 ` Luca Boccassi
2020-10-09 10:32 ` Bruce Richardson
2020-10-09 12:51 ` Luca Boccassi
2020-10-09 13:39 ` Bruce Richardson
2020-10-09 14:19 ` [dpdk-dev] [PATCH v2] build: skip detecting libpcap via pcap-config Bruce Richardson
2020-10-09 14:54 ` Luca Boccassi
2020-10-12 15:12 ` David Marchand
2020-10-12 12:02 ` David Marchand
2020-10-12 12:47 ` Bruce Richardson
2020-10-12 12:48 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008170805.GF1106@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).