From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C22AA04BC; Fri, 9 Oct 2020 15:54:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CC341D68D; Fri, 9 Oct 2020 15:52:29 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CCD451D68D for ; Fri, 9 Oct 2020 15:52:26 +0200 (CEST) IronPort-SDR: 2XiIM8tnG9lnqYt39LgsJY26alWEe1dmpfHzYJnB0xVAPI6v/PwKGKer/5cQlgYC0xz1u+sde0 1Ox0KHwIdPzw== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="164696530" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="164696530" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 06:52:24 -0700 IronPort-SDR: 1rAJd1zQk0jGxD8XWZyrT0G/3UZxApMa+geAdIDM6KxUOaLy67CZpHCOc5jAAG5Z8LFtFcy2fG 4IfHj4hZhwvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="354854749" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 09 Oct 2020 06:52:23 -0700 Received: from sivswdev10.ir.intel.com (sivswdev10.ir.intel.com [10.237.217.4]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 099DqMs7014782; Fri, 9 Oct 2020 14:52:22 +0100 Received: by sivswdev10.ir.intel.com (Postfix, from userid 28780) id 7FC84180090F; Fri, 9 Oct 2020 14:52:22 +0100 (IST) From: Mairtin o Loingsigh To: jasvinder.singh@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com Cc: dev@dpdk.org, brendan.ryan@intel.com, mairtin.oloingsigh@intel.com, david.coyle@intel.com Date: Fri, 9 Oct 2020 14:50:43 +0100 Message-Id: <20201009135045.8505-1-mairtin.oloingsigh@intel.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20201006162319.7981-1-mairtin.oloingsigh@intel.com> References: <20201006162319.7981-1-mairtin.oloingsigh@intel.com> Subject: [dpdk-dev] [PATCH v5 0/2] net: add CRC run-time checks and AVX512/VPCLMULQDQ based CRC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patchset makes two significant enhancements to the CRC modules of the rte_net library: 1) Adds run-time selection of the optimal architecture-specific CRC path. Previously the selection was solely made at compile-time, meaning it could only be built and run on the same generation of CPU. Adding run-time selection ability means this can be used from distro packages and/or DPDK can be compiled on an older CPU and run on a newer CPU. 2) Adds an optimized CRC implementation based on the AVX512 and VPCLMULQDQ instruction sets. For further details, please see the commit messages of the individual patches. v5: * Tidied-up the ifdef checks for RTE_ARCH_* and compiler support of CRC paths, as per review comments: * All ifdef checks removed from API function definitions and moved into helper functions. v4: * Fixed build issue when older version of meson is used (0.47.1). * Addressed review comments: * remove Intel copyright header from neon CRC file. * tidy-up of register initialisation. v3: * Re-submitted v2 as encountered problems when originally submitting it. v2: * Added support for run-time selection of optimal architecture-specific CRC, based on v1 review comment. * Added full working AVX512/VPCLMULQDQ support for CRC32-Ethernet and CRC16-CCITT. v1: * Initial version, with incomplete AVX512/VPCLMULQDQ support for CRC32-Ethernet only. Mairtin o Loingsigh (2): net: add run-time architecture specific CRC selection net: add support for AVX512/VPCLMULQDQ based CRC app/test/test_crc.c | 11 +- config/x86/meson.build | 6 +- doc/guides/rel_notes/release_20_11.rst | 6 + lib/librte_net/meson.build | 89 ++++- lib/librte_net/net_crc.h | 45 +++ lib/librte_net/net_crc_avx512.c | 423 ++++++++++++++++++++++ lib/librte_net/{net_crc_neon.h => net_crc_neon.c} | 26 +- lib/librte_net/{net_crc_sse.h => net_crc_sse.c} | 34 +- lib/librte_net/rte_net_crc.c | 162 +++++++-- lib/librte_net/rte_net_crc.h | 4 +- 10 files changed, 722 insertions(+), 84 deletions(-) create mode 100644 lib/librte_net/net_crc.h create mode 100644 lib/librte_net/net_crc_avx512.c rename lib/librte_net/{net_crc_neon.h => net_crc_neon.c} (95%) rename lib/librte_net/{net_crc_sse.h => net_crc_sse.c} (94%) -- 2.12.3