From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A812A04BC; Fri, 9 Oct 2020 17:59:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFA7C1D700; Fri, 9 Oct 2020 17:59:51 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 967D61D6FE for ; Fri, 9 Oct 2020 17:59:50 +0200 (CEST) IronPort-SDR: Y7KYRsr++7Sy8cOFxVtrqGnLKczAWIrg3XgSkQTZ1HUa6NyuyLTHpHovSPX4GBHMMmkriAX4LG damAZVi2aQFQ== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="153335502" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="153335502" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 08:59:48 -0700 IronPort-SDR: 5XNSsSwMiYN3402WUiCQjq0UuQQs6cgfTzgX9XSuMIIsYre6d2zLENUBMWyP2n9KXXsmHMfOFC quFkCjpTiINQ== X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="519762328" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.3.76]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Oct 2020 08:59:46 -0700 Date: Fri, 9 Oct 2020 16:59:42 +0100 From: Bruce Richardson To: John Alexander Cc: "dev@dpdk.org" Message-ID: <20201009155942.GE1474@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] Meson Minimum Version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 24, 2020 at 02:22:03PM +0000, John Alexander wrote: > Hi, > > I've submitted a patch that uses new features of Meson, specifically the directory patch aspect of the subproject feature. This requires a minimum Meson version of 0.55.0. How do we go about getting the community to accept a more recent version of Meson and getting the Travis server upgraded too so the CI builds succeed? > > Patch link for reference: http://patches.dpdk.org/patch/78675/ > > Kind Regards, > John Alexander. Hi John, this meson version change came up for discussion at the last DPDK technical board meeting, and some concerns were expressed about the jump in version and how it might impact those trying to package DPDK. However, looking at your proposed patch, I wonder though if we really need to globally bump the meson version, and whether we can limit the requirements to just windows builds - which is what your patch targets. Would the following change to your patch work for you? It keeps the minimum meson version at 0.47.1 but then later does a windows-specific version check, printing out an error message if requirements not met? /Bruce $ git diff diff --git a/config/meson.build b/config/meson.build index 69f2aeb60..fd48c9828 100644 --- a/config/meson.build +++ b/config/meson.build @@ -14,6 +14,11 @@ foreach env:supported_exec_envs set_variable('is_' + env, exec_env == env) endforeach +# for windows, we need meson 0.55 +if is_windows and meson.version().version_compare('< 0.55') + error('Require meson 0.55 to build on windows') +endif + # MS linker requires special treatment. # TODO: use cc.get_linker_id() with Meson >= 0.54 is_ms_linker = is_windows and (cc.get_id() == 'clang') diff --git a/meson.build b/meson.build index 9e061c73b..7dba3264e 100644 --- a/meson.build +++ b/meson.build @@ -8,7 +8,7 @@ project('DPDK', 'C', files('VERSION')).stdout().strip(), license: 'BSD', default_options: ['buildtype=release', 'default_library=static'], - meson_version: '>= 0.55.0' + meson_version: '>= 0.47.1' ) # set up some global vars for compiler, platform, configuration, etc.