From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8262FA04B6; Mon, 12 Oct 2020 11:37:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 170021D635; Mon, 12 Oct 2020 11:37:43 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 28C351D62C for ; Mon, 12 Oct 2020 11:37:40 +0200 (CEST) IronPort-SDR: L1uNegJUEmSqLcyulM4zPQsBcynSpikA55w54LA5NaqfS70gi30t6J+Sat8rKjyf1NG0dZDCwl wYnhxqX3r0lg== X-IronPort-AV: E=McAfee;i="6000,8403,9771"; a="145034787" X-IronPort-AV: E=Sophos;i="5.77,366,1596524400"; d="scan'208";a="145034787" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 02:37:38 -0700 IronPort-SDR: NNytd4RjvyHipRR/Ns3TsGsf+Xmumo9NRGVD00jkmF9XL8iLEPAfEyZomzPiAerH+3RfcLug8Y 1U6pnEf4TgcA== X-IronPort-AV: E=Sophos;i="5.77,366,1596524400"; d="scan'208";a="529892557" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.38.166]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Oct 2020 02:37:37 -0700 Date: Mon, 12 Oct 2020 10:37:32 +0100 From: Bruce Richardson To: "Guo, Jia" Cc: "Power, Ciara" , "dev@dpdk.org" , "Xing, Beilei" Message-ID: <20201012093732.GA565@bricha3-MOBL.ger.corp.intel.com> References: <20200807155859.63888-1-ciara.power@intel.com> <20200930130415.11211-1-ciara.power@intel.com> <20200930130415.11211-5-ciara.power@intel.com> <67502c03bcf84485b217599dffd32419@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67502c03bcf84485b217599dffd32419@intel.com> Subject: Re: [dpdk-dev] [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 10, 2020 at 02:07:15AM +0000, Guo, Jia wrote: > Hi, power > > > -----Original Message----- > > From: Power, Ciara > > Sent: Friday, October 9, 2020 10:03 PM > > To: Guo, Jia ; dev@dpdk.org > > Cc: Xing, Beilei > > Subject: RE: [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth > > > > Hi Jeff, > > > > >-----Original Message----- > > >From: Guo, Jia > > >Sent: Friday 9 October 2020 04:03 > > >To: Power, Ciara ; dev@dpdk.org > > >Cc: Xing, Beilei > > >Subject: RE: [PATCH v3 04/18] net/i40e: add checks for max SIMD > > >bitwidth > > > > > >Hi, power > > > > > >> -----Original Message----- > > >> From: Power, Ciara > > >> Sent: Wednesday, September 30, 2020 9:04 PM > > >> To: dev@dpdk.org > > >> Cc: Power, Ciara ; Xing, Beilei > > >> ; Guo, Jia > > >> Subject: [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth > > >> > > >> When choosing a vector path to take, an extra condition must be > > >> satisfied to ensure the max SIMD bitwidth allows for the CPU enabled > > path. > > >> > > >> Cc: Beilei Xing > > >> Cc: Jeff Guo > > >> > > >> Signed-off-by: Ciara Power > > >> --- > > >> drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++------ > > >> 1 file changed, 13 insertions(+), 6 deletions(-) > > >> > > >> diff --git a/drivers/net/i40e/i40e_rxtx.c > > >> b/drivers/net/i40e/i40e_rxtx.c index 60b33d20a1..9b535b52fa 100644 > > >> --- a/drivers/net/i40e/i40e_rxtx.c > > >> +++ b/drivers/net/i40e/i40e_rxtx.c > > >> @@ -3098,7 +3098,8 @@ static eth_rx_burst_t > > >> i40e_get_latest_rx_vec(bool > > >> scatter) { #if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT) > > >> -if > > >> (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) > > >> +if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) && > > >> +rte_get_max_simd_bitwidth() >= > > > > > >Nitpick: I think if consistent to keep alignment for open parenthesis > > >in this patch set would be better. Do you think so? > > > > > > > This file doesn't seem to have any if statements indented as you suggest, > > Some do have a double indent for the continued line as I have done here > > though. > > > > Sorry, maybe I didn't say clear, what I said is the "CHECK" as below when use checkpatch.pl to guaranty the patch's format. > > CHECK: Alignment should match open parenthesis > #733: FILE: drivers/net/i40e/i40e_rxtx.c:3102: > + if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) && > + rte_get_max_simd_bitwidth() >= RTE_MAX_256_SIMD) > Did you run checkpatch using the DPDK "checkpatches.sh" script? In that script there are a list of things to ignore, one of which is "PARENTHESIS_ALIGNMENT", so that should not be flagged here. It's also not flagged in patchwork by the CI system. /Bruce