From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH v2] build: skip detecting libpcap via pcap-config
Date: Mon, 12 Oct 2020 13:47:33 +0100 [thread overview]
Message-ID: <20201012124733.GC565@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8yLcPDsMzVvEnpiY9P24rnD5auCQbxOA17ArFkvjpb4Mg@mail.gmail.com>
On Mon, Oct 12, 2020 at 02:02:19PM +0200, David Marchand wrote:
> On Fri, Oct 9, 2020 at 4:19 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > When compiling for a slightly different architecture, e.g. 32-bit on 64-bit
> > systems using CFLAGS rather than a cross-file, the pcap-config utility can
> > often return parameters that are unusable for the build in question, i.e.
> > providing the native 64-bit library paths rather than checking for 32-bit
> > equivalent.
> >
> > Since many distros now include a version of libpcap with a
> > pkg-config file, and for those that don't find-library should work ok as a
> > fallback, we can explicitly just use pkg-config in the dependency search,
> > causing meson to skip trying to use pcap-config.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> I also hit (this?) issue on a fc32 with both 32-bit and 64-bit pcap installed.
> Can you confirm?
>
It looks to be the same general issue. Does adding this patch fix things?
When compiling 32-bit on 64-bit you generally need to be sure to set
PKG_CONFIG_LIBDIR in your environment to point to the appropriate path. It
might also serve to fix things in this instance, if not set.
> If so, we might want to backport this as I get the same problem with v19.11.4.
>
Good idea, I don't think it will break anything.
/Bruce
next prev parent reply other threads:[~2020-10-12 12:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 17:05 [dpdk-dev] [RFC PATCH] build: use libpcap only from pkg-config Bruce Richardson
2020-10-08 17:08 ` Bruce Richardson
2020-10-09 9:09 ` Luca Boccassi
2020-10-09 10:32 ` Bruce Richardson
2020-10-09 12:51 ` Luca Boccassi
2020-10-09 13:39 ` Bruce Richardson
2020-10-09 14:19 ` [dpdk-dev] [PATCH v2] build: skip detecting libpcap via pcap-config Bruce Richardson
2020-10-09 14:54 ` Luca Boccassi
2020-10-12 15:12 ` David Marchand
2020-10-12 12:02 ` David Marchand
2020-10-12 12:47 ` Bruce Richardson [this message]
2020-10-12 12:48 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012124733.GC565@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).