From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70425A04B7; Tue, 13 Oct 2020 17:05:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A56861DBBD; Tue, 13 Oct 2020 17:04:58 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id CCE5D1DAAB for <dev@dpdk.org>; Tue, 13 Oct 2020 17:04:56 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id n9so4283867pgt.8 for <dev@dpdk.org>; Tue, 13 Oct 2020 08:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SqlYdJV+zDbrzT20SFAdEUO6FQ4pFx4U/erbbvM/igc=; b=Y4F1ZAvWEimXAQVFIJHfnLPLsBrd3n9sgQg9YnAsLkHevpx40fFZukz3DTIYNUFBpP yWohshthKLk1DQpedlVCCTZxaX8VneegasPPub6Amt43ygRi8xB3xd4ckfOQ+rcT2oL8 i5YpkmEo6zl0kF3Sqecixjy9kYbwZ/RSWGNHWFUi8ardRJAWlPKNS1fJfRMnN4xlZZp2 /FGQQtT/NEa3YtTn0zBoxSjBBOn4I0oGj+/JEyWjmj5I376MuDVaNRuinnOUSJHlde24 491N+IysUo9qqlq0YgDwoSJ9PxlhD/Gm4HPrJwjfXCHjCngpdGE4Yh7nCvu///nZvlSV rXtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SqlYdJV+zDbrzT20SFAdEUO6FQ4pFx4U/erbbvM/igc=; b=lvalNETF+RC2vuwh0aX8qjTjxj1d2Jo92IcvUiXmNhWO09/BEJdW2u/3wmBW1Fz6Pn Q7w5ghxhC0RQKLOvOmV/GRUmAM9Gc//4IlXAxE+WpqPatwIX0AaV/E7sL+MtwB9GvU4Z LvE+wRpu0LQaz0gF/bUdr6tk0Yvp8HnCEyGqDJ7/hoOK5E4Kc5zJigta1AXfYgaVy9Mq v45c7fgM059eZFHdGZgQPTC2q/+NoLhvmfs90pR5BwIIgyHGKB3RnbUyem08IRs1qzpw LwZKdqmxijXinkeRkufjnfwiDnNfEjDqJ3zWgF+uVpUJJx/mKD0gbGtX59nG63S0PODL ZMPw== X-Gm-Message-State: AOAM530OPTDn1jlRANxG1HyupFPsln5fOVqmBCeOjvoj5RUebKyAQpaj SHxka5+NVQQDFfnxPlZ8AokuSQ== X-Google-Smtp-Source: ABdhPJzNdtGba9ZtriVL0zlL9+PIcmjlGp7VsncgRrDukuB468+qzlN7cq8Kbrm0maL2id7CcGDQ6A== X-Received: by 2002:a62:7d14:0:b029:155:2add:290e with SMTP id y20-20020a627d140000b02901552add290emr48530pfc.41.1602601495020; Tue, 13 Oct 2020 08:04:55 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x4sm17155419pfj.114.2020.10.13.08.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 08:04:54 -0700 (PDT) Date: Tue, 13 Oct 2020 08:04:46 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Thomas Monjalon <thomas@monjalon.net> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, dev@dpdk.org, techboard@dpdk.org, Min Hu <humin29@huawei.com> Message-ID: <20201013080446.792a3d19@hermes.local> In-Reply-To: <2290585.EWI7AWl3IT@thomas> References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <3382071.xncihUvvZe@thomas> <fc5dd269-e336-18d5-cafd-d22f9e30e6a4@oktetlabs.ru> <2290585.EWI7AWl3IT@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, 13 Oct 2020 11:05:07 +0200 Thomas Monjalon <thomas@monjalon.net> wrote: > 13/10/2020 10:31, Andrew Rybchenko: > > On 10/13/20 12:53 AM, Thomas Monjalon wrote: > > > 12/10/2020 18:46, Ferruh Yigit: > > >> Queue stats are stored in 'struct rte_eth_stats' as array and array size > > >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > > >> > > >> As a result of technical board discussion, decided to remove the queue > > >> statistics from 'struct rte_eth_stats' in the long term. > > >> > > >> Instead PMDs should represent the queue statistics via xstats, this > > >> gives more flexibility on the number of the queues supported. > > > > > > Yes > > > > I like Stephen's idea to have dedicated API to get stats per > > queue. Of course it is doable via getting xstats by IDs, > > but IMHO it is over-complicated. From the other hand > > it sounds like a duplication to have it in xstats and > > dedicated API (basically the same as we have for basic > > stats and xstats). > > Please read my proposal to have fixed ids for common stats > and fixed id ranges for stats per queue: > https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf > (slide 11) > > Looks good. if id's are known than should be possible to go from port/queue to xstats id. FYI - the inclusion of CRC in counters goes back to a Cisco vs Juniper fight. Cisco has more people wasting time on standards committees so they always get their way into the standards bodies.