From: SteveX Yang <stevex.yang@intel.com> To: dev@dpdk.org Cc: jia.guo@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, konstantin.ananyev@intel.com, SteveX Yang <stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v5 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default Date: Wed, 14 Oct 2020 09:19:41 +0000 Message-ID: <20201014091945.1934-2-stevex.yang@intel.com> (raw) In-Reply-To: <20201014091945.1934-1-stevex.yang@intel.com> when application presets the max rx packet length and expected mtu at the same time, driver need identify if the preset max frame size can hold mtu data and Ether overhead completely. if not, adjust the max frame size via mtu_set ops within dev_configure. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Signed-off-by: SteveX Yang <stevex.yang@intel.com> --- drivers/net/e1000/em_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index d050eb478..d2cf318f8 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -432,10 +432,22 @@ eth_em_configure(struct rte_eth_dev *dev) { struct e1000_interrupt *intr = E1000_DEV_PRIVATE_TO_INTR(dev->data->dev_private); + uint16_t frame_size = dev->data->mtu + E1000_ETH_OVERHEAD; + int rc = 0; PMD_INIT_FUNC_TRACE(); intr->flags |= E1000_FLAG_NEED_LINK_UPDATE; + /** + * Reset the max frame size via mtu_set ops if preset max frame + * cannot hold MTU data and Ether overhead. + */ + if (frame_size > dev->data->dev_conf.rxmode.max_rx_pkt_len) { + rc = eth_em_mtu_set(dev, dev->data->mtu); + if (rc != 0) + return rc; + } + PMD_INIT_FUNC_TRACE(); return 0; -- 2.17.1
next prev parent reply other threads:[~2020-10-14 9:21 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-16 5:52 [dpdk-dev] [PATCH v1 0/5] fix default max mtu size when device configured SteveX Yang 2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang 2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 2/5] net/igc: " SteveX Yang 2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 3/5] net/ice: " SteveX Yang 2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 4/5] net/iavf: " SteveX Yang 2020-09-16 5:52 ` [dpdk-dev] [PATCH v1 5/5] net/i40e: " SteveX Yang 2020-09-16 14:41 ` Ananyev, Konstantin [not found] ` <DM6PR11MB4362E5FF332551D12AA20017F93E0@DM6PR11MB4362.namprd11.prod.outlook.com> 2020-09-17 12:18 ` Ananyev, Konstantin 2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 0/5] fix default max mtu size when device configured SteveX Yang 2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang 2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 2/5] net/igc: " SteveX Yang 2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 3/5] net/ice: " SteveX Yang 2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 4/5] net/i40e: " SteveX Yang 2020-09-22 10:47 ` Ananyev, Konstantin 2020-09-22 1:23 ` [dpdk-dev] [PATCH v2 5/5] net/iavf: " SteveX Yang 2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 0/5] fix default max mtu size when device configured SteveX Yang 2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang 2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 2/5] net/igc: " SteveX Yang 2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 3/5] net/ice: " SteveX Yang 2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 4/5] net/i40e: " SteveX Yang 2020-09-23 4:09 ` [dpdk-dev] [PATCH v3 5/5] net/iavf: " SteveX Yang 2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 0/5] fix default max mtu size when device configured SteveX Yang 2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 1/5] net/e1000: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang 2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 2/5] net/igc: " SteveX Yang 2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 3/5] net/ice: " SteveX Yang 2020-09-29 11:59 ` Zhang, Qi Z 2020-09-29 23:01 ` Ananyev, Konstantin 2020-09-30 0:34 ` Zhang, Qi Z [not found] ` <DM6PR11MB4362515283D00E27A793E6B0F9330@DM6PR11MB4362.namprd11.prod.outlook.com> 2020-09-30 2:32 ` Zhang, Qi Z 2020-10-14 15:38 ` Ferruh Yigit [not found] ` <DM6PR11MB43628BBF9DCE7CC4D7C05AD8F91E0@DM6PR11MB4362.namprd11.prod.outlook.com> 2020-10-19 10:49 ` Ananyev, Konstantin 2020-10-19 13:07 ` Ferruh Yigit 2020-10-19 14:07 ` Ananyev, Konstantin 2020-10-19 14:28 ` Ananyev, Konstantin 2020-10-19 18:01 ` Ferruh Yigit 2020-10-20 9:07 ` Ananyev, Konstantin 2020-10-20 12:29 ` Ferruh Yigit 2020-10-21 9:47 ` Ananyev, Konstantin 2020-10-21 10:36 ` Ferruh Yigit 2020-10-21 10:44 ` Ananyev, Konstantin 2020-10-21 10:53 ` Ferruh Yigit 2020-10-19 18:05 ` Ferruh Yigit [not found] ` <DM6PR11MB4362F936BFC715BF6BABBAD0F91F0@DM6PR11MB4362.namprd11.prod.outlook.com> 2020-10-20 8:13 ` Ferruh Yigit 2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 4/5] net/i40e: " SteveX Yang 2020-09-28 6:55 ` [dpdk-dev] [PATCH v4 5/5] net/iavf: " SteveX Yang 2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 0/5] fix default max mtu size when device configured SteveX Yang 2020-10-14 9:19 ` SteveX Yang [this message] 2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 2/5] net/igc: fix max mtu size packets with vlan tag cannot be received by default SteveX Yang 2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 3/5] net/ice: " SteveX Yang 2020-10-14 11:35 ` Zhang, Qi Z 2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 4/5] net/i40e: " SteveX Yang 2020-10-14 10:30 ` Ananyev, Konstantin 2020-10-14 9:19 ` [dpdk-dev] [PATCH v5 5/5] net/iavf: " SteveX Yang 2020-10-14 11:43 ` [dpdk-dev] [PATCH v5 0/5] fix default max mtu size when device configured Zhang, Qi Z 2020-10-22 8:48 ` [dpdk-dev] [PATCH v6 0/2] " SteveX Yang 2020-10-22 8:48 ` [dpdk-dev] [PATCH v6 1/2] app/testpmd: fix max rx packet length for VLAN packets SteveX Yang 2020-10-22 16:22 ` Ferruh Yigit 2020-10-22 8:48 ` [dpdk-dev] [PATCH v6 2/2] librte_ethdev: fix MTU size exceeds max rx packet length SteveX Yang 2020-10-22 16:31 ` Ferruh Yigit 2020-10-22 16:52 ` Ananyev, Konstantin 2020-10-28 3:03 ` [dpdk-dev] [PATCH v7 0/1] fix default max mtu size when device configured SteveX Yang 2020-10-28 3:03 ` [dpdk-dev] [PATCH v7 1/1] app/testpmd: fix max rx packet length for VLAN packets SteveX Yang 2020-10-29 8:41 ` Ferruh Yigit 2020-11-02 8:52 ` [dpdk-dev] [PATCH v8 0/2] fix default max mtu size when device configured SteveX Yang 2020-11-02 8:52 ` [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets SteveX Yang 2020-11-02 11:48 ` Ferruh Yigit 2020-11-03 13:29 ` Ferruh Yigit 2020-11-04 16:51 ` Thomas Monjalon 2020-11-04 17:07 ` Ferruh Yigit 2020-11-04 17:55 ` Thomas Monjalon 2020-11-04 20:19 ` Ferruh Yigit 2020-11-04 20:39 ` Thomas Monjalon 2020-11-05 8:54 ` Andrew Rybchenko [not found] ` <DM6PR11MB43622CC5DF485DD034037CD3F9EE0@DM6PR11MB4362.namprd11.prod.outlook.com> 2020-11-05 10:37 ` Ferruh Yigit 2020-11-05 10:44 ` Thomas Monjalon 2020-11-05 10:48 ` Thomas Monjalon 2020-11-05 10:50 ` Ferruh Yigit 2020-11-05 13:52 ` Olivier Matz 2020-11-05 15:11 ` Lance Richardson 2020-11-05 15:56 ` Ferruh Yigit 2020-11-05 16:23 ` Lance Richardson 2020-11-05 17:44 ` [dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length adjustment Thomas Monjalon 2020-11-05 18:02 ` Lance Richardson 2020-11-05 18:11 ` Ferruh Yigit 2020-11-05 18:18 ` Thomas Monjalon 2020-11-05 10:49 ` [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets Ferruh Yigit 2020-11-02 8:52 ` [dpdk-dev] [PATCH v8 2/2] doc: annouce deprecation of jumbo frame flag condition SteveX Yang 2020-11-02 11:50 ` Ferruh Yigit 2020-11-02 13:18 ` Andrew Rybchenko 2020-11-02 13:58 ` Ferruh Yigit 2020-11-02 16:05 ` Ananyev, Konstantin [not found] ` <DM6PR11MB43625C5CF594BEDC9CE479F7F9110@DM6PR11MB4362.namprd11.prod.outlook.com> 2020-11-24 17:46 ` Ferruh Yigit 2020-11-27 12:19 ` Andrew Rybchenko 2020-11-27 17:08 ` Bruce Richardson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201014091945.1934-2-stevex.yang@intel.com \ --to=stevex.yang@intel.com \ --cc=beilei.xing@intel.com \ --cc=dev@dpdk.org \ --cc=jia.guo@intel.com \ --cc=jingjing.wu@intel.com \ --cc=konstantin.ananyev@intel.com \ --cc=qi.z.zhang@intel.com \ --cc=qiming.yang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git