From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAF56A04B7; Wed, 14 Oct 2020 16:03:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A9A81DD85; Wed, 14 Oct 2020 16:03:50 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 838041BEEA for ; Wed, 14 Oct 2020 16:03:47 +0200 (CEST) IronPort-SDR: 2FPdB0rF2vclRmH1+pubuG3qWY0/rpn9ZMkJVBD1As4U0cOWXASQwzpxbKEh3e5g9xhUA8qIh2 eaI4MiWbgHOw== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="166173219" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="166173219" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 07:03:45 -0700 IronPort-SDR: 1Goj0lY7nm2slNjxxBZarsjQbgW+qbIx1A9pJ9Wskkd27aXdNjOe6eB+J6GcdHT2yOz6dS1OJh AZVMlhKyN8tw== X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="314169822" Received: from bricha3-mobl.ger.corp.intel.com ([10.254.145.91]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 14 Oct 2020 07:03:41 -0700 Date: Wed, 14 Oct 2020 15:03:36 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Jeff Guo , jingjing.wu@intel.com, qi.z.zhang@intel.com, beilei.xing@intel.com, dev@dpdk.org, haiyue.wang@intel.com, Olivier Matz Message-ID: <20201014140336.GH1513@bricha3-MOBL.ger.corp.intel.com> References: <20200909025415.6185-1-jia.guo@intel.com> <20201013081734.47507-1-jia.guo@intel.com> <0257ccb2-88eb-a49a-77f9-9e611f3c266a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0257ccb2-88eb-a49a-77f9-9e611f3c266a@intel.com> Subject: Re: [dpdk-dev] [PATCH v8] net/iavf: support flex desc metadata extraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 14, 2020 at 01:31:39PM +0100, Ferruh Yigit wrote: > On 10/13/2020 9:17 AM, Jeff Guo wrote: > > Enable metadata extraction for flexible descriptors in AVF, that would > > allow network function directly get metadata without additional parsing > > which would reduce the CPU cost for VFs. The enabling metadata > > extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS > > flexible descriptors, and the VF could negotiate the capability of > > the flexible descriptor with PF and correspondingly configure the > > specific offload at receiving queues. > > > > Signed-off-by: Jeff Guo > > Acked-by: Haiyue Wang > > --- > > v8: > > rebase patch for apply issue > > > > v7: > > clean some useless and add doc > > > > v6: > > rebase patch > > > > v5: > > remove ovs configure since ovs is not protocol extraction > > > > v4: > > add flex desc type in rx queue for handling vector path > > handle ovs flex type > > > > v3: > > export these global symbols into .map > > > > v2: > > remove makefile change and modify the rxdid handling > > --- > > config/rte_config.h | 3 + > > doc/guides/nics/intel_vf.rst | 16 + > > doc/guides/rel_notes/release_20_11.rst | 6 + > > drivers/net/iavf/iavf.h | 24 +- > > drivers/net/iavf/iavf_ethdev.c | 394 ++++++++++++++++++++++ > > drivers/net/iavf/iavf_rxtx.c | 252 ++++++++++++-- > > drivers/net/iavf/iavf_rxtx.h | 168 +++++---- > > drivers/net/iavf/iavf_rxtx_vec_common.h | 3 + > > drivers/net/iavf/iavf_vchnl.c | 22 +- > > drivers/net/iavf/meson.build | 2 + > > drivers/net/iavf/rte_pmd_iavf.h | 250 ++++++++++++++ > > drivers/net/iavf/rte_pmd_iavf_version.map | 13 + > > 12 files changed, 1039 insertions(+), 114 deletions(-) > > create mode 100644 drivers/net/iavf/rte_pmd_iavf.h > > > > diff --git a/config/rte_config.h b/config/rte_config.h > > index 03d90d78bc..2c53072c3d 100644 > > --- a/config/rte_config.h > > +++ b/config/rte_config.h > > @@ -127,6 +127,9 @@ > > #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4 > > #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4 > > +/* iavf defines */ > > +#undef RTE_LIBRTE_IAVF_16BYTE_RX_DESC > > + > > Hi Jeff, > > The 'RTE_LIBRTE_IAVF_16BYTE_RX_DESC' was already there, not introduced with > this patch, so I think better to add this change as different patch. > > Also not sure if we want to add more config options to the 'rte_config.h', > indeed otherway around and we are trying to get rid of as much as compile > time optios. > cc'ed Bruce too. > Actually, there is also patchset [1] to consider, which changes the format of these values in the header file. It's better to not "undef" the not set values, as that prevents someone from setting them via cflags/c_args when building. /Bruce [1] http://patches.dpdk.org/project/dpdk/list/?series=11928