From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48A57A04DB; Thu, 15 Oct 2020 12:12:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72DB81BCB4; Thu, 15 Oct 2020 12:11:56 +0200 (CEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by dpdk.org (Postfix) with ESMTP id 898BA1BBD1; Thu, 15 Oct 2020 12:11:53 +0200 (CEST) X-Originating-IP: 86.254.165.59 Received: from u256.net (lfbn-poi-1-843-59.w86-254.abo.wanadoo.fr [86.254.165.59]) (Authenticated sender: grive@u256.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id DF6F6FF80E; Thu, 15 Oct 2020 10:11:51 +0000 (UTC) Date: Thu, 15 Oct 2020 12:11:42 +0200 From: =?utf-8?Q?Ga=C3=ABtan?= Rivet To: Long Li Cc: dev@dpdk.org, Long Li , stable@dpdk.org Message-ID: <20201015101142.or6nuf675qtwgmws@u256.net> References: <1601683308-18738-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1601683308-18738-1-git-send-email-longli@linuxonhyperv.com> Subject: Re: [dpdk-dev] [PATCH] net/failsafe: check correct error code while handling sub-device add X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/10/20 17:01 -0700, Long Li wrote: > From: Long Li > > When adding a sub-device, it's possible that the sub-device is configured > successfully but later fails to start. This error should not be masked. > The driver needs to check the error status to prevent endless loop of > trying to start the sub-device. > > fixes (ae80146c5a1b net/failsafe: fix removed device handling) > > cc: stable@dpdk.org > Signed-off-by: Long Li > --- > drivers/net/failsafe/failsafe_private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h > index 651578a..c58c0de 100644 > --- a/drivers/net/failsafe/failsafe_private.h > +++ b/drivers/net/failsafe/failsafe_private.h > @@ -497,7 +497,7 @@ int failsafe_eth_new_event_callback(uint16_t port_id, > fs_err(struct sub_device *sdev, int err) > { > /* A device removal shouldn't be reported as an error. */ > - if (sdev->remove == 1 || err == -EIO) > + if (sdev->remove == 1 && err == -EIO) > return rte_errno = 0; > return err; > } > -- > 1.8.3.1 > This bug has been fixed by the following commit: http://mails.dpdk.org/archives/dev/2020-October/185921.html Thanks for validating this other fix Li, it has been integrated. This patch can be dropped (nack). -- Gaƫtan