From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C61FA04DC; Thu, 15 Oct 2020 13:29:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C95A21DC0E; Thu, 15 Oct 2020 13:29:18 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 027AA1DBC3 for ; Thu, 15 Oct 2020 13:29:15 +0200 (CEST) IronPort-SDR: 5JtuOOJUPZpO7G0inzr5a5MZmmj9AYWtg2amnIUda3IBoZDk6t4hYmWlXQq8LqivKY4KllnWDQ VSIUJHNK2z1Q== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="251016161" X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="251016161" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 04:29:12 -0700 IronPort-SDR: opUxnkivcOZ8U9JRwyvStoFRbtieK/T4f23bFvbfny97nXigBkvaN/1fN8BzHqWpF89+FKuZhf GvJMji5S0e5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="531218963" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga005.jf.intel.com with ESMTP; 15 Oct 2020 04:29:09 -0700 Received: from sivswdev09.ir.intel.com (sivswdev09.ir.intel.com [10.237.217.48]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 09FBT9bN015632; Thu, 15 Oct 2020 12:29:09 +0100 Received: from sivswdev09.ir.intel.com (localhost [127.0.0.1]) by sivswdev09.ir.intel.com with ESMTP id 09FBT8iK023306; Thu, 15 Oct 2020 12:29:08 +0100 Received: (from lma25@localhost) by sivswdev09.ir.intel.com with LOCAL id 09FBT8M5023300; Thu, 15 Oct 2020 12:29:08 +0100 Date: Thu, 15 Oct 2020 12:29:08 +0100 From: "Liang, Ma" To: Anatoly Burakov Cc: dev@dpdk.org, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ray Kinsella , Neil Horman , david.hunt@intel.com, konstantin.ananyev@intel.com, jerinjacobk@gmail.com, bruce.richardson@intel.com, timothy.mcdaniel@intel.com, gage.eads@intel.com, chris.macnamara@intel.com Message-ID: <20201015112908.GA16411@sivswdev09.ir.intel.com> References: <532f45c5d79b4c30a919553d322bb66e91534466.1602258833.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v6 04/10] ethdev: add simple power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14 Oct 14:30, Anatoly Burakov wrote: > From: Liang Ma > > Add a simple API to allow getting address of next RX descriptor from the > PMD, as well as release notes information. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > Acked-by: Konstantin Ananyev > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 3a31f94367..005faba455 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -4119,6 +4119,32 @@ __rte_experimental > int rte_eth_tx_burst_mode_get(uint16_t port_id, uint16_t queue_id, > struct rte_eth_burst_mode *mode); > > +/** > + * Retrieve the wake up address for the receive queue. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue_id > + * The Rx queue on the Ethernet device for which information > + * will be retrieved. > + * @param wake_addr > + * The pointer point to the address which is used for monitoring. > + * @param expected > + * The pointer point to value to be expected when descriptor is set. > + * @param mask > + * The pointer point to comparison bitmask for the expected value. > + * need add the comment of data_sz. > + * @return > + * - 0: Success. > + * -ENOTSUP: Operation not supported. > + * -EINVAL: Invalid parameters. > + * -ENODEV: Invalid port ID. > + */ > +__rte_experimental > +int rte_eth_get_wake_addr(uint16_t port_id, uint16_t queue_id, > + volatile void **wake_addr, uint64_t *expected, uint64_t *mask, > + uint8_t *data_sz); > + > /** > * Retrieve device registers and register attributes (number of registers and > * register size) > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h > index 35cc4fb186..76b179de42 100644 > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -655,6 +655,32 @@ typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev, > */ > typedef int (*eth_fec_set_t)(struct rte_eth_dev *dev, uint32_t fec_capa); > > +/** > + * @internal > + * Get address of memory location whose contents will change whenever there is > + * new data to be received on an RX queue. > + * > + * @param rxq > + * Ethdev queue pointer. > + * @param tail_desc_addr > + * The pointer point to where the address will be stored. > + * @param expected > + * The pointer point to value to be expected when descriptor is set. > + * @param mask > + * The pointer point to comparison bitmask for the expected value. > + * @param data_sz > + * Data size for the expected value (can be 1, 2, 4, or 8 bytes) > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success > + * @retval -EINVAL > + * Invalid parameters > + */ > +typedef int (*eth_get_wake_addr_t)(void *rxq, volatile void **tail_desc_addr, > + uint64_t *expected, uint64_t *mask, uint8_t *data_sz); > + > /** > * @internal A structure containing the functions exported by an Ethernet driver. > */ > @@ -801,6 +827,8 @@ struct eth_dev_ops { > /**< Get Forward Error Correction(FEC) mode. */ > eth_fec_set_t fec_set; > /**< Set Forward Error Correction(FEC) mode. */ > + eth_get_wake_addr_t get_wake_addr; > + /**< Get next RX queue ring entry address. */ > }; > > /** > diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map > index f8a0945812..6c2ea5996d 100644 > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -232,6 +232,7 @@ EXPERIMENTAL { > rte_eth_fec_get_capability; > rte_eth_fec_get; > rte_eth_fec_set; > + rte_eth_get_wake_addr; > }; > > INTERNAL { > -- > 2.17.1