From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 509F0A04DB; Fri, 16 Oct 2020 10:13:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E572B1EAE9; Fri, 16 Oct 2020 10:13:28 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 38D431EADD for ; Fri, 16 Oct 2020 10:13:27 +0200 (CEST) IronPort-SDR: aNBL1BLBfFe2OMDRIx6ovGUgqVi7CUY5rbR0YkUCEHp7bFtzwO3j9d1KhrjR0i9dMmm8EZvpk3 Ui7ghdrZWrQA== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="163937606" X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="163937606" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 01:13:24 -0700 IronPort-SDR: yyyR6HRKhRZ/AKz4+Uy6OlZKFE/1/1lgTcXcswgh2/leqqNLgJYXfjbFMnjYmYV/TDKrzPIOyK Yz7uImWHoDMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="521096810" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.239]) by fmsmga006.fm.intel.com with ESMTP; 16 Oct 2020 01:13:22 -0700 From: Ciara Power To: dev@dpdk.org Cc: viktorin@rehivetech.com, ruifeng.wang@arm.com, jerinj@marvell.com, drc@linux.vnet.ibm.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, david.marchand@redhat.com, Ciara Power Date: Fri, 16 Oct 2020 09:13:02 +0100 Message-Id: <20201016081320.186775-1-ciara.power@intel.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20200807155859.63888-1-ciara.power@intel.com> References: <20200807155859.63888-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v8 00/18] add max SIMD bitwidth to EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A number of components in DPDK have optional AVX-512 or other vector code paths which can be selected at runtime. Rather than having each component provide its own mechanism to select a code path, this patchset adds support for a single setting to control what code paths are used. This can be used to enable some non-default code paths e.g. ones using AVX-512, but also to limit the code paths to certain vector widths, or to scalar code only, which is useful for testing. The max SIMD bitwidth setting can be set by the app itself through use of the available API, or can be overriden by a commandline argument passed by the user. v8: - Rebased onto main. - Fixed ACL patch to include AVX512X32 as a default option, and modified docs to reflect that change. v7: Fixed comments on v6. v6: - Rebased on main. - Added ACL patch based on recent changes to the library. - Modified net library patch based on recent rework. - Fixed comments on the v5. v5: Fixed cc list. v4: - Dropped LPM patch as the lookupx4 function is called from SSE/NEON headers, so is already on a vectorised path. Given the performance impact for an unnecessary change, it was decided the check is not needed. - Renamed enum values for readability. - Added patch to add check for node library. - Reworked net patch to choose default handlers rather than scalar by default. - Updated some Doxygen comments. - Fixed some other small comments on v3. v3: - Added patch to add check for LPM lib - Modified default max bitwidth for Arm to disable max SIMD bitwidth, which will allow for SVE. - Added "0" as an acceptable value for command-line flag, which internally is used as UINT16_MAX to essentially disable max SIMD bitwidth limits. - Made suggested changes to net lib patch. - Rebased onto main. v2: - Added some documentation. - Modified default max bitwidth for Arm. - Moved mlx5 condition check into existing check vec support function. - Added max SIMD bitwidth checks to some libraries. Ciara Power (18): eal: add max SIMD bitwidth doc: add detail on using max SIMD bitwidth net/i40e: add checks for max SIMD bitwidth net/axgbe: add checks for max SIMD bitwidth net/bnxt: add checks for max SIMD bitwidth net/enic: add checks for max SIMD bitwidth net/fm10k: add checks for max SIMD bitwidth net/iavf: add checks for max SIMD bitwidth net/ice: add checks for max SIMD bitwidth net/ixgbe: add checks for max SIMD bitwidth net/mlx5: add checks for max SIMD bitwidth net/virtio: add checks for max SIMD bitwidth distributor: add checks for max SIMD bitwidth member: add checks for max SIMD bitwidth efd: add checks for max SIMD bitwidth net: add checks for max SIMD bitwidth node: choose vector path at runtime acl: add checks for max SIMD bitwidth doc/guides/howto/avx512.rst | 36 ++++++ doc/guides/howto/index.rst | 1 + doc/guides/linux_gsg/eal_args.include.rst | 16 +++ .../prog_guide/env_abstraction_layer.rst | 32 +++++ .../prog_guide/packet_classif_access_ctrl.rst | 16 +-- drivers/net/axgbe/axgbe_rxtx.c | 3 +- drivers/net/bnxt/bnxt_ethdev.c | 6 +- drivers/net/enic/enic_rxtx_vec_avx2.c | 3 +- drivers/net/fm10k/fm10k_ethdev.c | 11 +- drivers/net/i40e/i40e_rxtx.c | 18 ++- drivers/net/iavf/iavf_rxtx.c | 16 ++- drivers/net/ice/ice_rxtx.c | 20 ++- drivers/net/ixgbe/ixgbe_rxtx.c | 5 +- drivers/net/mlx5/mlx5_rxtx_vec.c | 2 + drivers/net/virtio/virtio_ethdev.c | 9 +- lib/librte_acl/rte_acl.c | 49 ++++++-- lib/librte_acl/rte_acl.h | 1 + lib/librte_distributor/rte_distributor.c | 3 +- lib/librte_eal/arm/include/rte_vect.h | 2 + lib/librte_eal/common/eal_common_options.c | 66 ++++++++++ lib/librte_eal/common/eal_internal_cfg.h | 8 ++ lib/librte_eal/common/eal_options.h | 2 + lib/librte_eal/include/rte_eal.h | 40 ++++++ lib/librte_eal/ppc/include/rte_vect.h | 2 + lib/librte_eal/rte_eal_exports.def | 2 + lib/librte_eal/rte_eal_version.map | 2 + lib/librte_eal/x86/include/rte_vect.h | 2 + lib/librte_efd/rte_efd.c | 7 +- lib/librte_member/rte_member_ht.c | 3 +- lib/librte_net/rte_net_crc.c | 116 +++++++++++++----- lib/librte_node/ip4_lookup.c | 14 ++- lib/librte_node/ip4_lookup_neon.h | 2 +- lib/librte_node/ip4_lookup_sse.h | 2 +- 33 files changed, 430 insertions(+), 87 deletions(-) create mode 100644 doc/guides/howto/avx512.rst -- 2.22.0