From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 571AEA04DB;
	Fri, 16 Oct 2020 17:52:26 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D0FB11EA85;
	Fri, 16 Oct 2020 17:52:23 +0200 (CEST)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id E91E01E91E
 for <dev@dpdk.org>; Fri, 16 Oct 2020 17:52:20 +0200 (CEST)
IronPort-SDR: GweJMW1nNfrUPiAekHfBFMAjkhz6dTb2mpA0bD+WWHqwUyi86eJ6VnaF4cQTuiXhCmMynrl1wI
 /2f3TGZ/Ez6w==
X-IronPort-AV: E=McAfee;i="6000,8403,9776"; a="166709502"
X-IronPort-AV: E=Sophos;i="5.77,383,1596524400"; d="scan'208";a="166709502"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 16 Oct 2020 08:52:19 -0700
IronPort-SDR: +wsDQgKQhcqsElGuW3pReY/nuUEmi3H02m5goFCVSs2eq8b0YamasWtVZIkv5VSOs7MrmacMe0
 EdPEEgixYAFg==
X-IronPort-AV: E=Sophos;i="5.77,383,1596524400"; d="scan'208";a="464718119"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.54.208])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 16 Oct 2020 08:52:17 -0700
Date: Fri, 16 Oct 2020 16:52:13 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Kinsella, Ray" <mdr@ashroe.eu>
Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>,
 Thomas Monjalon <thomas@monjalon.net>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
 Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Kevin Traynor <ktraynor@redhat.com>
Message-ID: <20201016155213.GA1121@bricha3-MOBL.ger.corp.intel.com>
References: <20201016093806.20061-1-david.marchand@redhat.com>
 <20201016102711.11926-1-david.marchand@redhat.com>
 <7f7c1ac8-947f-40d1-bf21-4e13c196ec72@ashroe.eu>
 <CAJFAV8wA-033wVWhM27BVPTvJpvAsNjGi8FDVd+SWpFaWtxO6g@mail.gmail.com>
 <6c1fa16a-891c-b822-3252-47aec20c6bcc@ashroe.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6c1fa16a-891c-b822-3252-47aec20c6bcc@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Oct 16, 2020 at 04:48:59PM +0100, Kinsella, Ray wrote:
> 
> On 16/10/2020 12:22, David Marchand wrote:
> > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray <mdr@ashroe.eu> wrote:
> >>
> >>
> >> The windows exports and the map files, feels like duplication of effort.
> >> Could we massage one into the other during the build?
> > 
> > That's what is done with map-to-win.py, unless we have one exception
> > when the full library is not ready, like EAL.
> > 
> > https://git.dpdk.org/dpdk/tree/lib/meson.build#n152
> > https://git.dpdk.org/dpdk/tree/buildtools/map_to_win.py#n27
> > 
> 
> Thinking about this again - future work might be to check if a .def exists.
> And then to warn in checkpatch if one is modified without the other?
> 
Possibly, but right now there is only the one .def override file, for EAL,
and a better use of effort is to close the gap between windows and other
versions so that it can be removed completely.

$ find lib/ drivers/ -name *.def
lib/librte_eal/rte_eal_exports.def

/Bruce