From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3681DA04DC; Mon, 19 Oct 2020 17:25:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3D18FC50; Mon, 19 Oct 2020 17:25:40 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 428F4FC48 for ; Mon, 19 Oct 2020 17:25:38 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id b6so141584pju.1 for ; Mon, 19 Oct 2020 08:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3Dhbadpy99WdWTK7sUNuCDbt+K1EkTNc9JkwMYUtbDc=; b=u+kPNzs8ehO0NT6F/lS1PNKk+XtZMY6kvH2qApUEdVq8FVNvDOG3U0PuS2/yW2aDVr bfZRWbUcTOmY0aA2oJWBfoMIMpyL+kKYK+yl5n7KZdyG5qCUzT03H6IMG0lXQ2cdXqjS 62sdOB4xVlNWeCv+kV87Fj70Qw53T3PyM3nqHhEkPQk9tZ3bketw01/dnoLUkpKNwzbC TO79fl8KpeWtgAYBQb546EUkqIfOwiWW6BkvdMbjJEQdwaZSQRatEiCjjwqkzH4LlMAp OaIzJ5rM85hF+iyJ7VX7e/tPul3WzY8DOJ4mdex9P8ji1zqS/J8JCWA+q6aIhiF2VLqR K5vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3Dhbadpy99WdWTK7sUNuCDbt+K1EkTNc9JkwMYUtbDc=; b=Poq4R3b8IP9LOpm21aL6zXI5JNRKZdYwbfoZmpjRUK05Xy1+vriI9t/N5vvyENKDRx XiqbzZxXxIy9VE5/6DN39t5DyRgE7tPu/4+Q9GLlt+hd36qcevVLcTc3E3uEHWO2cU60 qo747IeeLsnuJ9DQHk/sGa730Fsv1YD746zMOUWEGC004n/O9C0zwHzlkg43AM6PqUMb WoMBRve3gWRCatgJMOE/cMzK7f9Ym0noxD9aKwxM86rAureGxTF4Uhlcx2KcksXi5Jjn R6/JCTjUBn45hguUYv5Q6IiTHPnKKVJRLmpSg+bS8m3aP94dyWuc2Lf1KqE3n+yuhS/p Qe6w== X-Gm-Message-State: AOAM530YsK+mOjRDLCFGH5Vwybd7X5Qmhz44Qe4gLPopg2ltqdCtFAbM 8NLz8ZtpAwU+LQSJ2phj3ABqag== X-Google-Smtp-Source: ABdhPJyzFQRe6jUqsYxfcVuMDbKu9Pp7p1hJifV5tJpV2OdtMpbj68kE98cgqQ/R/298p7KZ2eP4gQ== X-Received: by 2002:a17:902:8482:b029:d2:6356:82f8 with SMTP id c2-20020a1709028482b02900d2635682f8mr260846plo.75.1603121136348; Mon, 19 Oct 2020 08:25:36 -0700 (PDT) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x29sm199870pfp.152.2020.10.19.08.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 08:25:36 -0700 (PDT) Date: Mon, 19 Oct 2020 08:25:28 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Bruce Richardson , Dmitry Kozlyuk , dev@dpdk.org, david.marchand@redhat.com, olivier.matz@6wind.com Message-ID: <20201019082528.78e78811@hermes.local> In-Reply-To: <8528402.suE0oRMLcd@thomas> References: <20200814173441.23086-1-stephen@networkplumber.org> <20200817103740.GA496@bricha3-MOBL.ger.corp.intel.com> <20200817081137.3b00fd39@hermes.lan> <8528402.suE0oRMLcd@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: add option to put timestamp on console output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 19 Oct 2020 16:11:19 +0200 Thomas Monjalon wrote: > There was no ack or conclusion for this patch. > > 17/08/2020 17:11, Stephen Hemminger: > > On Mon, 17 Aug 2020 11:37:40 +0100 > > Bruce Richardson wrote: > > > > > On Fri, Aug 14, 2020 at 12:20:28PM -0700, Stephen Hemminger wrote: > > > > On Fri, 14 Aug 2020 22:09:11 +0300 > > > > Dmitry Kozlyuk wrote: > > > > > > > > > On Fri, 14 Aug 2020 11:45:49 -0700, Stephen Hemminger wrote: > > > > > > On Fri, 14 Aug 2020 21:39:29 +0300 > > > > > > Dmitry Kozlyuk wrote: > > > > > [...] > > > > > > FreeBsd doesn't go through the same log code. > > > > > > > > > > Then --log-timestamp shouldn't appear on FreeBSD if it's unsupported. > > > > > > > > Was using same ifdef that is already there. There are several options already > > > > (like syslog facility) which do nothing on FreeBSD anyway. > > > > > > > While that is correct, I think that we really should support this on > > > FreeBSD also, since I don't think there is any technical reason we can't do > > > so, right? Even a sub-optimal solution where the timestamp write and log > > > write are non-atomic would be better than nothing. > > > > > > /Bruce > > > > FreeBSD now just uses default log stream (stdout). > > Linux has log stream to syslog and stdout. > > > > There is nothing Linux specific in the old or new code. > > The Linux code could just be moved to common, and both could use it. > > That is a separate patch, and someone with expertise and build setup for FreeBSD needs to do it. > > Lets fix FreeBSD to use common code for logging, then timestamp option can be added?