Re: [dpdk-dev] [PATCH v5 0/8] Rework build macros

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Oct 20, 2020 at 09:17:11AM +0200, David Marchand wrote:
> On Mon, Oct 19, 2020 at 10:27 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 15/10/2020 17:05, Bruce Richardson:
> > > Following on from discussion in RFC v1 and v2 of this set, this version
> > > reworks the automated macros defined by meson to indicate if a
> > > particular library or driver is enabled in the build. However, while it
> > > does so, it also maintains compatibility with previous releases to ease the
> > > transition for any apps using the older macros, which already has to
> > > contend with a change in DPDK build-system and to switch over to picking up
> > > the library names from pkg-config.
> > >
> > > Advantages of this rework:
> > > * Much cleaner having standard macros
> > > * No need for defining the format of macros for each class
> > > * Shorter macros (for the most part)
> > >
> > > Disadvantages:
> > > * Potentially requires application changes
> > > * Inconsistency between the auto-defined macros and the other feature-set
> > >   ones.
> > >
> > > Bruce Richardson (8):
> > >   app: fix missing dependencies
> > >   examples/l2fwd-crypto: fix missing dependency
> > >   build: add defines for compatibility with make build
> > >   qat: build from common folder
> > >   build: remove library name from version map filename
> > >   devtools/test-null: load all drivers from directory
> > >   build: standardize component names and defines
> > >   build: replace use of old build macros
> >
> > Applied, thanks
> 
> kni compilation is broken, can you have a look?
> http://mails.dpdk.org/archives/test-report/2020-October/160621.html
> 
> Thanks.
> 
Yes, will do so.

/Bruce