From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAF9EA04DD; Tue, 20 Oct 2020 10:37:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4A1CBB9E; Tue, 20 Oct 2020 10:37:49 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id ECD765A59 for ; Tue, 20 Oct 2020 10:37:46 +0200 (CEST) IronPort-SDR: e+osPxiA6The1nLQNTbOKA5tbVgWiaT+FsdLYAmNY2ARWX79IyXY0tZpWVFAQ9VsXXgNDhgV1I YJU2PGLyaxDg== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="231370651" X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="231370651" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 01:37:45 -0700 IronPort-SDR: rQQFi94PFPbCLF7W8hnVjaE27DCDrzVmspG4m8oHCz4duzDe1Vrxqnbutlbm1y/rmz/XmREJjO 8lElKgcYkC6w== X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="532968029" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.248.1]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Oct 2020 01:37:44 -0700 Date: Tue, 20 Oct 2020 09:37:41 +0100 From: Bruce Richardson To: David Marchand Cc: dev , Andrew Rybchenko , "Yigit, Ferruh" , Luca Boccassi , Thomas Monjalon Message-ID: <20201020083741.GC558@bricha3-MOBL.ger.corp.intel.com> References: <20200916164429.244847-1-bruce.richardson@intel.com> <20201015150554.950838-1-bruce.richardson@intel.com> <2393931.9fLth6X2y1@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v5 0/8] Rework build macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 20, 2020 at 09:17:11AM +0200, David Marchand wrote: > On Mon, Oct 19, 2020 at 10:27 PM Thomas Monjalon wrote: > > > > 15/10/2020 17:05, Bruce Richardson: > > > Following on from discussion in RFC v1 and v2 of this set, this version > > > reworks the automated macros defined by meson to indicate if a > > > particular library or driver is enabled in the build. However, while it > > > does so, it also maintains compatibility with previous releases to ease the > > > transition for any apps using the older macros, which already has to > > > contend with a change in DPDK build-system and to switch over to picking up > > > the library names from pkg-config. > > > > > > Advantages of this rework: > > > * Much cleaner having standard macros > > > * No need for defining the format of macros for each class > > > * Shorter macros (for the most part) > > > > > > Disadvantages: > > > * Potentially requires application changes > > > * Inconsistency between the auto-defined macros and the other feature-set > > > ones. > > > > > > Bruce Richardson (8): > > > app: fix missing dependencies > > > examples/l2fwd-crypto: fix missing dependency > > > build: add defines for compatibility with make build > > > qat: build from common folder > > > build: remove library name from version map filename > > > devtools/test-null: load all drivers from directory > > > build: standardize component names and defines > > > build: replace use of old build macros > > > > Applied, thanks > > kni compilation is broken, can you have a look? > http://mails.dpdk.org/archives/test-report/2020-October/160621.html > > Thanks. > Yes, will do so. /Bruce