From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B32C3A04DC; Tue, 20 Oct 2020 16:33:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 499E9BAF6; Tue, 20 Oct 2020 16:32:23 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 68B92BAB8 for ; Tue, 20 Oct 2020 16:32:18 +0200 (CEST) IronPort-SDR: qQypXHyby4MJam3RMm6TxLgJhcitUUSiXWcRhejbJ+XF+Au7MeQNEZxOfbXh6trpgb6NxK9NuQ DkfTRV3eWkWw== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="163725981" X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="163725981" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 07:32:16 -0700 IronPort-SDR: aTNqr48gYou4P+shsXJCL4GKFm2wSCpiFon3P+KT7wrqwygTBwMzgnrIGNuGpjiAYoo48KzMXu RJq3YAqLh8Cg== X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="523525726" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.248.1]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Oct 2020 07:32:12 -0700 Date: Tue, 20 Oct 2020 15:32:08 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, ktraynor@redhat.com, ali.rizvi@emumba.com, muhammad.ahamd@emumba.com, david.hunt@intel.com, reshma.pattan@intel.com, konstantin.ananyev@intel.com, ferruh.yigit@intel.com, jerinj@marvell.com, honnappa.nagarahalli@arm.com, olivier.matz@6wind.com, lijuan.tu@intel.com, ohilyard@iol.unh.edu, mb@smartsharesystems.com, viacheslavo@nvidia.com, stephen@networkplumber.org, anatoly.burakov@intel.com, Felix Moessbauer Message-ID: <20201020143208.GF558@bricha3-MOBL.ger.corp.intel.com> References: <20200715155409.9835-3-felix.moessbauer@siemens.com> <20200915083836.18805-2-felix.moessbauer@siemens.com> <8907870.d7ml1O1rqj@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8907870.d7ml1O1rqj@thomas> Subject: Re: [dpdk-dev] [PATCH 1/2] Fix build of apps with external dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 20, 2020 at 04:12:58PM +0200, Thomas Monjalon wrote: > 15/09/2020 10:38, Felix Moessbauer: > > This fix initializes the dependency object with the external > > dependency list. Previously, the external dependencies were > > just ignored. > > > > Signed-off-by: Felix Moessbauer > > --- > > --- a/app/meson.build > > +++ b/app/meson.build > > if build > > - dep_objs = [] > > + dep_objs = ext_deps > > Bruce, do you confirm this is required? > Yes, it looks a correct fix, as indeed the ext_deps value is ignored in the file. Acked-by: Bruce Richardson