From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1F43A04DC; Tue, 20 Oct 2020 17:44:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 178FCBB96; Tue, 20 Oct 2020 17:44:19 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 966A1B34C for ; Tue, 20 Oct 2020 17:44:16 +0200 (CEST) IronPort-SDR: ZsOPVqXxP5sGBBg05hFp1oI8KCfnnHgulm0n0RN/NTEKrF/GNBPRWmy67a/vsOBWlDkVDBRhH8 wK42oRPC90/w== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="164620202" X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="164620202" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 08:44:12 -0700 IronPort-SDR: 3UWrKn/GUQ4dCw0ce0dHcuDrd33HDOvdCLGq7BnmlNAthqqRaxW1S4bPludo9er/d8Xq7r6Loz lT0SGCJWQd+g== X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="465972127" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.248.1]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Oct 2020 08:44:11 -0700 Date: Tue, 20 Oct 2020 16:44:08 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20201020154408.GK558@bricha3-MOBL.ger.corp.intel.com> References: <20201020130722.304989-1-bruce.richardson@intel.com> <1741910.NPnI57ggvb@thomas> <20201020153206.GH558@bricha3-MOBL.ger.corp.intel.com> <5606809.TihpGJyqmm@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5606809.TihpGJyqmm@thomas> Subject: Re: [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 20, 2020 at 05:38:43PM +0200, Thomas Monjalon wrote: > 20/10/2020 17:32, Bruce Richardson: > > On Tue, Oct 20, 2020 at 05:17:58PM +0200, Thomas Monjalon wrote: > > > 20/10/2020 17:03, Bruce Richardson: > > > > On Tue, Oct 20, 2020 at 04:29:18PM +0200, Thomas Monjalon wrote: > > > > > 20/10/2020 15:07, Bruce Richardson: > > > > > > Since a number of contributors to DPDK have submitted patches to > > > > > > DPDK under more than one email address, we should maintain a > > > > > > mailmap file to properly track their commits using "shortlog". It > > > > > > also helps fix up any mangled names, for example, with > > > > > > surname/firstname reversed, or with incorrect capitalization. > > > > > > > > > > I agree it helps fixing typos in names, that's why I have such file. > > > > > To be really useful, we should add every contributors. > > > > > > > > Surely not every contributor has multiple email addresses or their > > > > emails in multiple formats? > > > > > > > > > > > > > > > > Signed-off-by: Bruce Richardson --- > > > > > > > > > > > > while this list is almost certainly incomplete, this should serve > > > > > > as a reasonable start-point for building a more complete one. > > > > > > > > > > Do you want me to write a v2? > > > > > > > > > Feel free to. However, I think the contents should be limited to only > > > > those that need to be there. > > > > > > Misunderstanding then. The other usage I'm looking at, is your last > > > sentence above: " It also helps fix up any mangled names, for example, > > > with surname/firstname reversed, or with incorrect capitalization. " > > > This usage requires to have everyone listed. > > > > > I've only ever noticed a few instances in DPDK where people's names differ > > a little - for example, I think there is one instance in hundreds of > > commits from me where my surname is missing a capital letter, and three > > instances of surname/firstname reversal, and all of those are from 2014 or > > earlier. > > > > If most people's names are consistent in the repo then there is no need to > > add them. I'd view adding for cases like this to be on an as-needed basis, > > and largely leave it up to people to contribute names to the list when they > > see a problem. I would not think that there is any need to pro-actively add > > people to the list in case their name gets messed up in future, especially > > since, thanks to your work, the use of names has become much more > > consistent over the years. > > Yes it is because of Ferruh, David and myself fixing names. > I would prefer this check done in advance by contributors > and other maintainers. That's why I would like to share > a script and a big database of names which could be the mailmap. > That does make more sense, but I still find it strange to have to store the names of each contributor in the mailmap file to achieve this? If we have the few incorrect names stored here, can we not dynamically get the list of contributors from "shortlog"? /Bruce