From: Qi Zhang <qi.z.zhang@intel.com>
To: qiming.yang@intel.com
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Subject: [dpdk-dev] [PATCH 12/21] net/ice/base: return error directly
Date: Wed, 21 Oct 2020 06:48:37 +0800 [thread overview]
Message-ID: <20201020224846.1592682-13-qi.z.zhang@intel.com> (raw)
In-Reply-To: <20201020224846.1592682-1-qi.z.zhang@intel.com>
As there is nothing to unroll, return the error directly. Remove the label
as this is the only reference to that label.
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_sched.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ice/base/ice_sched.c b/drivers/net/ice/base/ice_sched.c
index 16314ef18e..7867d4fda8 100644
--- a/drivers/net/ice/base/ice_sched.c
+++ b/drivers/net/ice/base/ice_sched.c
@@ -2662,10 +2662,9 @@ ice_sched_cfg_agg(struct ice_port_info *pi, u32 agg_id,
/* Create new entry for new aggregator ID */
agg_info = (struct ice_sched_agg_info *)
ice_malloc(hw, sizeof(*agg_info));
- if (!agg_info) {
- status = ICE_ERR_NO_MEMORY;
- goto exit_reg_agg;
- }
+ if (!agg_info)
+ return ICE_ERR_NO_MEMORY;
+
agg_info->agg_id = agg_id;
agg_info->agg_type = agg_type;
agg_info->tc_bitmap[0] = 0;
@@ -2698,7 +2697,7 @@ ice_sched_cfg_agg(struct ice_port_info *pi, u32 agg_id,
/* Save aggregator node's TC information */
ice_set_bit(tc, agg_info->tc_bitmap);
}
-exit_reg_agg:
+
return status;
}
--
2.25.4
next prev parent reply other threads:[~2020-10-20 22:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 22:48 [dpdk-dev] [PATCH 00/21] ice: update base code Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 01/21] net/ice/base: add tunnel support for FDIR Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 02/21] net/ice/base: add NVM Write Response flags Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 03/21] net/ice/base: modify ptype bitmap for outer MAC Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 04/21] net/ice/base: rename ptype bitmap Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 05/21] net/ice/base: move sched function prototypes Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 06/21] net/ice/base: read security revision Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 07/21] net/ice/base: add functions to allocate and free a RSS global LUT Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 08/21] net/ice/base: add more capability to admin queue Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 09/21] net/ice/base: update to use package info from ice segment Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 10/21] net/ice/base: use malloc instead of calloc Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 11/21] net/ice/base: add support for class 5+ modules Qi Zhang
2020-10-20 22:48 ` Qi Zhang [this message]
2020-10-20 22:48 ` [dpdk-dev] [PATCH 13/21] net/ice/base: implement shared rate limiter Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 14/21] net/ice/base: recognize 860 as iSCSI port in CEE mode Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 15/21] net/ice/base: fix parameter name in comment Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 16/21] net/ice/base: support extended GPIO access Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 17/21] net/ice/base: remove duplicated AQ command flag setting Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 18/21] net/ice/base: introduce and use FLEX_ARRAY_SIZE where possible Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 19/21] net/ice/base: refactor RSS configure API Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 20/21] net/ice/base: add support for get/set RSS LUT to specify global LUT Qi Zhang
2020-10-20 22:48 ` [dpdk-dev] [PATCH 21/21] net/ice/base: update version Qi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020224846.1592682-13-qi.z.zhang@intel.com \
--to=qi.z.zhang@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).