From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 632D0A04DF; Wed, 21 Oct 2020 13:52:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 426A3AD07; Wed, 21 Oct 2020 13:52:54 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DC217AD06 for ; Wed, 21 Oct 2020 13:52:50 +0200 (CEST) IronPort-SDR: MZDF3tWt0GDKcnYttQHPEeAoxGaFP2OEcmexw2Pl7lXU+GmL8/87nuVmfPHFFNHt49wmfm/WK2 SkWsXBXzOEVw== X-IronPort-AV: E=McAfee;i="6000,8403,9780"; a="231545503" X-IronPort-AV: E=Sophos;i="5.77,401,1596524400"; d="scan'208";a="231545503" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2020 04:52:48 -0700 IronPort-SDR: ZwWsHtRQgz9kkDEv6IKB6sF5eq95XEt0jqh32CP7ehU1S6YT6cXopO3a6ogmyOEXouL+TA7+Tv ejT35YKVHqKw== X-IronPort-AV: E=Sophos;i="5.77,401,1596524400"; d="scan'208";a="533496711" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.249.97]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 21 Oct 2020 04:52:46 -0700 Date: Wed, 21 Oct 2020 12:52:43 +0100 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: Ruifeng.Wang@arm.com, Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com, Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com, dev@dpdk.org Message-ID: <20201021115243.GB592@bricha3-MOBL.ger.corp.intel.com> References: <1602600882-695-1-git-send-email-juraj.linkes@pantheon.tech> <1603280261-20206-1-git-send-email-juraj.linkes@pantheon.tech> <1603280261-20206-2-git-send-email-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1603280261-20206-2-git-send-email-juraj.linkes@pantheon.tech> Subject: Re: [dpdk-dev] [RFC PATCH v3 1/6] build: rename default Arm build to generic-armv8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 21, 2020 at 01:37:36PM +0200, Juraj Linkeš wrote: > The current machine='default' build name is not descriptive. The actual > default build is machine='native'. Add an alternative string which does > the same build and better describes what we're building: > machine='generic-armv8'. Leave machine='default' for backwards > compatibility. > > Signed-off-by: Juraj Linkeš --- > config/arm/meson.build | 31 ++++++++++++++++--------------- > config/meson.build | 3 --- 2 files changed, 16 insertions(+), 18 > deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > b49203fa8..c88e34a2b 100644 --- a/config/arm/meson.build +++ > b/config/arm/meson.build @@ -1,12 +1,13 @@ # SPDX-License-Identifier: > BSD-3-Clause # Copyright(c) 2017 Intel Corporation. # Copyright(c) 2017 > Cavium, Inc +# Copyright(c) 2020 PANTHEON.tech s.r.o. > > # for checking defines we need to use the correct compiler flags > march_opt = '-march=@0@'.format(machine) > > arm_force_native_march = false -arm_force_default_march = (machine == > 'default') +arm_force_generic_march = (machine == 'default' or machine > == 'generic-armv8') > Rather than having this just for arm, how about adding "generic" as a synonym for "default" at the top level, since it probably better describes what "default" does for all architectures.