From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] hash: use x86 common flag for jhash
Date: Thu, 22 Oct 2020 09:22:57 +0100 [thread overview]
Message-ID: <20201022082257.GD83@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201022075959.19638-1-david.marchand@redhat.com>
On Thu, Oct 22, 2020 at 09:59:59AM +0200, David Marchand wrote:
> jhash has been forgotten when factorising the x86 arch check.
>
> Fixes: dbf17d44f375 ("hash: use common x86 flag")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/librte_hash/rte_jhash.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h
> index 7a1eeff74e..f2446f081e 100644
> --- a/lib/librte_hash/rte_jhash.h
> +++ b/lib/librte_hash/rte_jhash.h
> @@ -91,7 +91,7 @@ __rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc,
> * Check key alignment. For x86 architecture, first case is always optimal
> * If check_align is not set, first case will be used
> */
> -#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32)
> +#if defined(RTE_ARCH_X86)
> const uint32_t *k = (const uint32_t *)key;
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2020-10-22 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 7:59 David Marchand
2020-10-22 8:22 ` Bruce Richardson [this message]
2020-10-22 20:08 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022082257.GD83@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).