[dpdk-dev] [PATCH 0/2] fips_validation: fix issues

[dpdk-dev] [PATCH 0/2] fips_validation: fix issues

[Fan Zhang]

This patch fixes two issues in FIPS validation sample application.

Fan Zhang (2):
  fips_validation: fix missed version line
  fips_validation: fix gcm test

 examples/fips_validation/fips_validation.c     |  2 +-
 examples/fips_validation/fips_validation_gcm.c |  1 -
 examples/fips_validation/main.c                | 10 +++++++---
 3 files changed, 8 insertions(+), 5 deletions(-)

-- 
2.26.2

[dpdk-dev] [PATCH 1/2] fips_validation: fix missed version line

[Fan Zhang]

This patch fixes the missing version line in the response file.

Fixes: 793650184099 ("examples/fips_validation: fix version compatibility")
Cc: marchana@marvell.com

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 examples/fips_validation/fips_validation.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c
index 7454a03b1..4c3ed80c8 100644
--- a/examples/fips_validation/fips_validation.c
+++ b/examples/fips_validation/fips_validation.c
@@ -118,7 +118,7 @@ fips_test_parse_header(void)
 	if (info.nb_vec_lines)
 		fips_test_parse_version();
 
-	for (i = 1; i < info.nb_vec_lines; i++) {
+	for (i = 0; i < info.nb_vec_lines; i++) {
 		if (!algo_parsed) {
 			if (strstr(info.vec[i], "AESVS")) {
 				algo_parsed = 1;
-- 
2.26.2

[dpdk-dev] [PATCH 2/2] fips_validation: fix gcm test

[Fan Zhang]

This patch fixes FIPS GCM test of the redundant plaintext string
write and insufficient test case support check for some corner
cases.

Fixes: d09abf2d1007 ("examples/fips_validation: update GCM test")
Cc: roy.fan.zhang@intel.com

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 examples/fips_validation/fips_validation_gcm.c |  1 -
 examples/fips_validation/main.c                | 10 +++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c
index df3caa267..250d09bf9 100644
--- a/examples/fips_validation/fips_validation_gcm.c
+++ b/examples/fips_validation/fips_validation_gcm.c
@@ -175,7 +175,6 @@ parse_test_gcm_writeback(struct fips_val *val)
 		if (vec.status == RTE_CRYPTO_OP_STATUS_SUCCESS) {
 			fprintf(info.fp_wr, "%s", PT_STR);
 			if (!info.interim_info.gcm_data.is_gmac) {
-				fprintf(info.fp_wr, "%s", PT_STR);
 				tmp_val.val = val->val;
 				tmp_val.len = vec.pt.len;
 
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 07532c956..f3678f056 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -927,10 +927,14 @@ prepare_gmac_xform(struct rte_crypto_sym_xform *xform)
 
 	if (rte_cryptodev_sym_capability_check_auth(cap,
 			auth_xform->key.length,
-			auth_xform->digest_length, 0) != 0) {
-		RTE_LOG(ERR, USER1, "PMD %s key length %u IV length %u\n",
+			auth_xform->digest_length,
+			auth_xform->iv.length) != 0) {
+
+		RTE_LOG(ERR, USER1,
+			"PMD %s key length %u Digest length %u IV length %u\n",
 				info.device_name, auth_xform->key.length,
-				auth_xform->digest_length);
+				auth_xform->digest_length,
+				auth_xform->iv.length);
 		return -EPERM;
 	}
 
-- 
2.26.2

Re: [dpdk-dev] [PATCH 0/2] fips_validation: fix issues

[Akhil Goyal]

> This patch fixes two issues in FIPS validation sample application.
> 
> Fan Zhang (2):
>   fips_validation: fix missed version line
>   fips_validation: fix gcm test
> 
>  examples/fips_validation/fips_validation.c     |  2 +-
>  examples/fips_validation/fips_validation_gcm.c |  1 -
>  examples/fips_validation/main.c                | 10 +++++++---
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
Applied to dpdk-next-crypto

Cc: stable@dpdk.org

Thanks.

Re: [dpdk-dev] [PATCH 2/2] fips_validation: fix gcm test

[Akhil Goyal]

Hi Fan,
> This patch fixes FIPS GCM test of the redundant plaintext string
> write and insufficient test case support check for some corner
> cases.
> 
> Fixes: d09abf2d1007 ("examples/fips_validation: update GCM test")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---

I believe part of this series is already applied. Please rebase this patchset.

Regards,
Akhil