From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D76D8A04DD; Thu, 22 Oct 2020 20:45:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F6045A9B; Thu, 22 Oct 2020 20:45:21 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 694865A97 for ; Thu, 22 Oct 2020 20:45:18 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id y1so1428800plp.6 for ; Thu, 22 Oct 2020 11:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version; bh=KD2e3eIyZ8n+u3L6KKuQwkvfwUx/BkykLoOa+zs/P2k=; b=faRbI0INJLmQwPJaa16qKu6kYT+jEVAH7duOlPTKRqU6tm3BoUUfw6GEOFsLQP4h0h lmTvmLWAm/zjgHn9O7jX14Uv158Lr1YFFB5KXcfYCTTl3Ng8c0+1ih1LlOqL/8Bt4mEw hq/Nl45/FWp1jinY/9id5kIgojGolaQYxN16U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=KD2e3eIyZ8n+u3L6KKuQwkvfwUx/BkykLoOa+zs/P2k=; b=raxRo0AppKukgARRToHsgyG5u46nFBfRZteaZAeAhwn0GadVXx4LD0ZtBaRMw9Y6RT sXe9IayQrU6YcRlzd078i/lUtqFrwYLnA/6CVooPeWcxiaXnH2KtStkWSDCCSV2z+pJN ruMwNotcDnwSs9gHrRmjmiiV5aSAiXPzRdtZsJi5xef+8RDNsFUkMCaGsLvlocySh7MF T3cjy5pFI+SnvL7xaxh1x/YcmRSYOyjtaRAOxmH8Jw0hnFdWTP7lSvixZ0z9pDkN0QMw KNzFglXnHp1oZ90vfPN6PckW2hA93bze/YtaELeyUdvOmdqapx8fHIZRIMSdqGxk+CmU Z43A== X-Gm-Message-State: AOAM532whAnupFvtc2su71eji4oK7tTNHirAR/UmS9BhVZE6uFz6awdZ d2oV9NsJqfRUw1TPutm1C9NmMQ== X-Google-Smtp-Source: ABdhPJwzRfJDkbQ0fhkw/s4Is6KySrIk4GV2q2tNa/or8PQ83rS+Fgfsy8BQ75mkghZGU5weahLAjw== X-Received: by 2002:a17:902:b689:b029:d5:e78f:65d1 with SMTP id c9-20020a170902b689b02900d5e78f65d1mr3623581pls.6.1603392316462; Thu, 22 Oct 2020 11:45:16 -0700 (PDT) Received: from localhost.localdomain ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id 198sm2976644pfx.26.2020.10.22.11.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 11:45:15 -0700 (PDT) From: Lance Richardson To: Ajit Khaparde , Somnath Kotur Cc: dev@dpdk.org Date: Thu, 22 Oct 2020 14:45:10 -0400 Message-Id: <20201022184510.182976-1-lance.richardson@broadcom.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] [PATCH] net/bnxt: fix incorrect boolean operator usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Use boolean AND operator instead of bitwise operator. Coverity issue: 323488 Fixes: b42c15c83e88 ("net/bnxt: support trusted VF") Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa2d9e00e..3ee4b5524 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1547,7 +1547,7 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev, if (rc) return rc; - if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) { + if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) { PMD_DRV_LOG(ERR, "Cannot add MAC address to a VF interface\n"); return -ENOTSUP; } -- 2.25.1