Out of place with linear buffers is supported by octeontx2 while not advertised. Cc: stable@dpdk.org Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities") Signed-off-by: Didier Pallard <didier.pallard@6wind.com> --- drivers/crypto/octeontx2/otx2_cryptodev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c index 02d2fd83bdcf..44da26c78d04 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev.c +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c @@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, RTE_CRYPTODEV_FF_HW_ACCELERATED | RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | RTE_CRYPTODEV_FF_IN_PLACE_SGL | + RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT | RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT | RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO | -- 2.20.1
>Subject: [PATCH] crypto/octeontx2: fix crypto OOP support > > Out of place with linear buffers is supported by octeontx2 > while not advertised. > > Cc: stable@dpdk.org > Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities") > Signed-off-by: Didier Pallard <didier.pallard@6wind.com> Cc below fixes line and then a blank line. > --- > drivers/crypto/octeontx2/otx2_cryptodev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c > b/drivers/crypto/octeontx2/otx2_cryptodev.c > index 02d2fd83bdcf..44da26c78d04 100644 > --- a/drivers/crypto/octeontx2/otx2_cryptodev.c > +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c > @@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv > __rte_unused, > RTE_CRYPTODEV_FF_HW_ACCELERATED | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > RTE_CRYPTODEV_FF_IN_PLACE_SGL | > + RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT | > RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | > RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT | > RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO | This feature flag is missing in the documentation of the PMD as well. doc/guides/cryptodevs/features/octeontx2.ini Same comment for http://patches.dpdk.org/patch/81947/
Out of place with linear buffers is supported by octeontx2 while not advertised. Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities") Cc: stable@dpdk.org Signed-off-by: Didier Pallard <didier.pallard@6wind.com> --- v2: * Add documentation. doc/guides/cryptodevs/features/octeontx2.ini | 1 + drivers/crypto/octeontx2/otx2_cryptodev.c | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/guides/cryptodevs/features/octeontx2.ini b/doc/guides/cryptodevs/features/octeontx2.ini index c7e418d826e1..b0d50ce98447 100644 --- a/doc/guides/cryptodevs/features/octeontx2.ini +++ b/doc/guides/cryptodevs/features/octeontx2.ini @@ -12,6 +12,7 @@ Protocol offload = Y In Place SGL = Y OOP SGL In LB Out = Y OOP SGL In SGL Out = Y +OOP LB In LB Out = Y RSA PRIV OP KEY QT = Y Symmetric sessionless = Y diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c index 02d2fd83bdcf..44da26c78d04 100644 --- a/drivers/crypto/octeontx2/otx2_cryptodev.c +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c @@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, RTE_CRYPTODEV_FF_HW_ACCELERATED | RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | RTE_CRYPTODEV_FF_IN_PLACE_SGL | + RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT | RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT | RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO | -- 2.20.1
Hi Ankur/Anoob,
> Subject: [PATCH v2] crypto/octeontx2: fix crypto OOP support
>
> Out of place with linear buffers is supported by octeontx2
> while not advertised.
>
> Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
> Cc: stable@dpdk.org
>
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> ---
Could you please Ack both these otx and otx2 patches.
>-----Original Message----- >From: Didier Pallard <didier.pallard@6wind.com> >Sent: Tuesday, October 27, 2020 8:51 PM >To: dev@dpdk.org >Cc: stable@dpdk.org; Ankur Dwivedi <adwivedi@marvell.com>; Anoob Joseph ><anoobj@marvell.com>; Akhil Goyal <akhil.goyal@nxp.com>; Tejasree Kondoj ><ktejasree@marvell.com> >Subject: [EXT] [PATCH v2] crypto/octeontx2: fix crypto OOP support > >External Email > >---------------------------------------------------------------------- >Out of place with linear buffers is supported by octeontx2 while not >advertised. > >Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities") >Cc: stable@dpdk.org > >Signed-off-by: Didier Pallard <didier.pallard@6wind.com> Acked-by: Ankur Dwivedi <adwivedi@marvell.com> >--- >v2: > * Add documentation. > > doc/guides/cryptodevs/features/octeontx2.ini | 1 + > drivers/crypto/octeontx2/otx2_cryptodev.c | 1 + > 2 files changed, 2 insertions(+) > >diff --git a/doc/guides/cryptodevs/features/octeontx2.ini >b/doc/guides/cryptodevs/features/octeontx2.ini >index c7e418d826e1..b0d50ce98447 100644 >--- a/doc/guides/cryptodevs/features/octeontx2.ini >+++ b/doc/guides/cryptodevs/features/octeontx2.ini >@@ -12,6 +12,7 @@ Protocol offload = Y > In Place SGL = Y > OOP SGL In LB Out = Y > OOP SGL In SGL Out = Y >+OOP LB In LB Out = Y > RSA PRIV OP KEY QT = Y > Symmetric sessionless = Y > >diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c >b/drivers/crypto/octeontx2/otx2_cryptodev.c >index 02d2fd83bdcf..44da26c78d04 100644 >--- a/drivers/crypto/octeontx2/otx2_cryptodev.c >+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c >@@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv >__rte_unused, > RTE_CRYPTODEV_FF_HW_ACCELERATED | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING >| > RTE_CRYPTODEV_FF_IN_PLACE_SGL | >+ RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT | > RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | > RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT | > RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO | >-- >2.20.1
> >----------------------------------------------------------------------
> >Out of place with linear buffers is supported by octeontx2 while not
> >advertised.
> >
> >Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Acked-by: Ankur Dwivedi <adwivedi@marvell.com>
> >---
Applied to dpdk-next-crypto
Thanks.