From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CBB6A04B5; Tue, 27 Oct 2020 11:30:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E9FA2BD5; Tue, 27 Oct 2020 11:30:24 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 2D9CB100C for ; Tue, 27 Oct 2020 11:30:20 +0100 (CET) IronPort-SDR: gydQfWOVZV0pFpG0NAiNgSsyFB0ZNypreaRTSLiC7v2VLHTkxT9e5l8uGb04urQwv3vgGbQGZJ S3/UJzEgtNDg== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="147912046" X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="147912046" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 03:30:19 -0700 IronPort-SDR: XVtd+DPGb8gFvGPHyDM2ETAxHitl+Mt21ZT5SajFVfFXSIhaDClJDaE5L1xzl3Cout68oeroV1 rzDcBPE0PZfA== X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="535733488" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.252.158]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 27 Oct 2020 03:30:14 -0700 Date: Tue, 27 Oct 2020 10:30:10 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "Phil.Yang@arm.com" , "vcchunga@amazon.com" , "Dharmik.Thakkar@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" Message-ID: <20201027103010.GC936@bricha3-MOBL.ger.corp.intel.com> References: <1602600882-695-1-git-send-email-juraj.linkes@pantheon.tech> <1603280261-20206-1-git-send-email-juraj.linkes@pantheon.tech> <1603280261-20206-4-git-send-email-juraj.linkes@pantheon.tech> <20201021120220.GC592@bricha3-MOBL.ger.corp.intel.com> <54e20244e1e841148669eb93b6b8876c@pantheon.tech> <20201021141319.GD592@bricha3-MOBL.ger.corp.intel.com> <20201021142753.GE592@bricha3-MOBL.ger.corp.intel.com> <03c562b977de41b3bf759a6d12e79015@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <03c562b977de41b3bf759a6d12e79015@pantheon.tech> Subject: Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 23, 2020 at 10:07:17AM +0000, Juraj Linkeš wrote: > > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Wednesday, October 21, 2020 4:28 PM > > To: Juraj Linkeš > > Cc: Ruifeng.Wang@arm.com; Honnappa.Nagarahalli@arm.com; > > Phil.Yang@arm.com; vcchunga@amazon.com; Dharmik.Thakkar@arm.com; > > jerinjacobk@gmail.com; hemant.agrawal@nxp.com; dev@dpdk.org > > Subject: Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu > > counts detection > > > > What could possibly work is to set the defaults for these to "0" as done in your > > patch, but thereafter have the resulting defaults set per-architecture, rather > > than globally. That would allow x86 to tune things more for native-style builds, > > while in all cases allowing user to override. > > > > /Bruce > > I'll change it so that per-arch (and for arm, per processor type) defaults are the defaults that will be used (when set to 0). I'd like to give users the option to use the discovery mechanism - I think we'll have to use another value with specific meaning and we can't use positive integers so I guess the best we can do is use -1 for this. > Well, if you want, if the defaults are set per-architecture, is you could use detection for the default values for the ARM builds if the build-type is set to "native" and the max_cores etc. are set to zero. For x86 that is almost certainly not what we want, so we'd use hard-coded values for those but no reason other architectures all need to do the same. /Bruce