DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>
Cc: keith.wiles@intel.com, dev@dpdk.org, henning.schild@siemens.com
Subject: Re: [dpdk-dev] [PATCH] Add build option to enable/disable AVX2 support
Date: Tue, 27 Oct 2020 11:47:03 +0000
Message-ID: <20201027114703.GG936@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201026143027.15246-1-felix.moessbauer@siemens.com>

On Mon, Oct 26, 2020 at 03:30:27PM +0100, Felix Moessbauer wrote:
> This patch introduces a meson option to disable the AVX2 support.
> If the build should be for a target without AVX2 support, the
> know can be turned to false, even if the compiler supports AVX2.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meson.build       | 3 ++-
>  meson_options.txt | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 0ee98be..2e2380c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -18,7 +18,8 @@ pktgen_conf = configuration_data()
>  cc = meson.get_compiler('c')
>  
>  add_project_arguments('-march=native', language: 'c')
> -if cc.has_argument('-mavx2')
> +
> +if get_option('enable-avx2') and cc.has_argument('-mavx2')
>  	add_project_arguments('-mavx2', language: 'c')
>  endif
>  add_project_arguments('-DALLOW_EXPERIMENTAL_API', language: 'c')

Hi,

This code does not appear in the upstream DPDK project [1]. This looks like
a pktgen patch instead, is this the case? If so, please put pktgen
somewhere in the patch title to make it easier to disposition.

Thanks,
/Bruce

[1] http://git.dpdk.org/dpdk/tree/meson.build

  reply	other threads:[~2020-10-27 11:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 14:30 Felix Moessbauer
2020-10-27 11:47 ` Bruce Richardson [this message]
2020-10-29 13:36 ` Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027114703.GG936@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=felix.moessbauer@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=keith.wiles@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git