From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 679C7A04B5; Tue, 27 Oct 2020 12:47:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2833B2BDB; Tue, 27 Oct 2020 12:47:14 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DF47D2BAA for ; Tue, 27 Oct 2020 12:47:11 +0100 (CET) IronPort-SDR: 24BuUhUeUBrD1jARpx6pP5McMobk0GDloYa9wBgYPDsjhTa1oO/W+U3P48R7+Gxlx7HvN/8m56 8LlTU4OSYOPA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="229701453" X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="229701453" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 04:47:10 -0700 IronPort-SDR: BrhqHmMGcpqmYVgAVhVdiQjhIZF5SNYrkAtUelFR/LjplZlrm9Ind6Yf/qmFWve3yVeYfo8dHr TfAQOnL7D88A== X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="535757200" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.252.158]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 27 Oct 2020 04:47:07 -0700 Date: Tue, 27 Oct 2020 11:47:03 +0000 From: Bruce Richardson To: Felix Moessbauer Cc: keith.wiles@intel.com, dev@dpdk.org, henning.schild@siemens.com Message-ID: <20201027114703.GG936@bricha3-MOBL.ger.corp.intel.com> References: <20201026143027.15246-1-felix.moessbauer@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026143027.15246-1-felix.moessbauer@siemens.com> Subject: Re: [dpdk-dev] [PATCH] Add build option to enable/disable AVX2 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 26, 2020 at 03:30:27PM +0100, Felix Moessbauer wrote: > This patch introduces a meson option to disable the AVX2 support. > If the build should be for a target without AVX2 support, the > know can be turned to false, even if the compiler supports AVX2. > > Signed-off-by: Felix Moessbauer > --- > meson.build | 3 ++- > meson_options.txt | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 0ee98be..2e2380c 100644 > --- a/meson.build > +++ b/meson.build > @@ -18,7 +18,8 @@ pktgen_conf = configuration_data() > cc = meson.get_compiler('c') > > add_project_arguments('-march=native', language: 'c') > -if cc.has_argument('-mavx2') > + > +if get_option('enable-avx2') and cc.has_argument('-mavx2') > add_project_arguments('-mavx2', language: 'c') > endif > add_project_arguments('-DALLOW_EXPERIMENTAL_API', language: 'c') Hi, This code does not appear in the upstream DPDK project [1]. This looks like a pktgen patch instead, is this the case? If so, please put pktgen somewhere in the patch title to make it easier to disposition. Thanks, /Bruce [1] http://git.dpdk.org/dpdk/tree/meson.build