From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F000A04B5; Tue, 27 Oct 2020 14:28:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0AB244C6B; Tue, 27 Oct 2020 14:28:05 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 010D72BF4 for ; Tue, 27 Oct 2020 14:28:03 +0100 (CET) IronPort-SDR: bR4x/SAyZDvjRGJlSoNGE5QT0iQQAetIphgMdjCK6vKeLe1r4dLt1lxulJbFAdnbtDEbykiPDn WsMaacOyrRjA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="147362550" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="147362550" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 06:28:02 -0700 IronPort-SDR: j1GNbx5k5i0sM1xstoa1KbFihyllYRJl+sfB9/l4ofjAsZW7vohpCUiGx4c03KtA7xdrew9Gei H6K7emexpm1g== X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="350530579" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.252.158]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 27 Oct 2020 06:27:58 -0700 Date: Tue, 27 Oct 2020 13:27:50 +0000 From: Bruce Richardson To: Ali Alnubani Cc: Ferruh Yigit , Leyi Rong , "qi.z.zhang@intel.com" , "wenzhuo.lu@intel.com" , Andrew Rybchenko , David Marchand , Raslan Darawsheh , "dev@dpdk.org" Message-ID: <20201027132750.GI936@bricha3-MOBL.ger.corp.intel.com> References: <20201027101926.112609-1-leyi.rong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] net/ice: add AVX512BW flag check both in build and runtime X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 27, 2020 at 01:12:20PM +0000, Ali Alnubani wrote: > Hi, > > > -----Original Message----- > > From: Ferruh Yigit > > Sent: Tuesday, October 27, 2020 1:57 PM > > To: Leyi Rong ; qi.z.zhang@intel.com; > > bruce.richardson@intel.com; wenzhuo.lu@intel.com; Ali Alnubani > > ; Andrew Rybchenko ; > > David Marchand > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] net/ice: add AVX512BW flag check both in build and > > runtime > > > > On 10/27/2020 10:19 AM, Leyi Rong wrote: > > > Intrinsic function __mm512_bsrli_epi128 should be used in the > > > environment which supports AVX512BW, so adds check for this flag. > > > > > > Fixes: 5dd3b8f3af34 ("net/ice: add AVX512 vector path") > > > > > > Signed-off-by: Leyi Rong > > > > Squashed into relevant commit in next-net, thanks. > > > > > > Andrew, Ali, David, > > > > Can you please confirm the issue is solved in the next-net/main? > > > > The build failures in CentOS 7, Ubuntu 18.04 and in OpenSUSE Leap 15.2 no longer reproduce. But we just noticed that Ubuntu 16.04.7 (gcc 5.4.0) is also failing with a different error: > > """ > drivers/net/ice/ice_rxtx_vec_avx512.c:1:0: error: bad value (skylake-avx512) for -march= switch > /* SPDX-License-Identifier: BSD-3-Clause > """ > Which is also caused by "net/ice: add AVX512 vector path". > I think we can drop the -march=skylake-avx512 flag in the build command for the avx512 file, since specifying the -mavx512f and -mavx512bw should be enough. Testing in an ubuntu 16.04 VM (which has 5.5 rather than 5.4 compiler, but should be ok), shows that the avx512 instruction set flags are recognised and enable the isntructions, which the -march one is not. /Bruce bruce@ubuntu-1604-vm:~$ gcc -mavx512f -mavx512bw -dM -E - < /dev/null | grep AVX #define __AVX512F__ 1 #define __AVX512BW__ 1 #define __AVX__ 1 #define __AVX2__ 1 bruce@ubuntu-1604-vm:~$ gcc -march=skylake-avx512 -dM -E - < /dev/null | grep AVX cc1: error: bad value (skylake-avx512) for -march= switch