DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com,
	Narcisa.Vasile@microsoft.com, talshn@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v2] eal: enable windows apps to run on non-admin users
Date: Wed, 28 Oct 2020 02:10:20 +0300
Message-ID: <20201028021020.0d5a5441@sovereign> (raw)
In-Reply-To: <20201026184458.8492-1-pallavi.kadam@intel.com>

On Mon, 26 Oct 2020 11:44:58 -0700, Pallavi Kadam wrote:
> Currently, since there is no runtime directory set, the code tries to
> create a file in C:\ which is only writable with administrator
> privileges. As a result, if the user is not admin, the application will
> fail.
> So, forcing no_shconf to 1 to prevent the code having to create files in
> the runtime directory.
> 
> Suggested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
>  lib/librte_eal/windows/eal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c
> index 6334aca03..105549de1 100644
> --- a/lib/librte_eal/windows/eal.c
> +++ b/lib/librte_eal/windows/eal.c
> @@ -295,6 +295,7 @@ rte_eal_init(int argc, char **argv)
>  		RTE_LOG(WARNING, EAL, "Multi-process support is requested, "
>  			"but not available.\n");
>  		internal_conf->in_memory = 1;
> +		internal_conf->no_shconf = 1;
>  	}
>  
>  	if (!internal_conf->no_hugetlbfs && (eal_hugepage_info_init() < 0)) {

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

  reply	other threads:[~2020-10-27 23:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 20:26 [dpdk-dev] [PATCH] eal: create a runtime directory on windows Pallavi Kadam
2020-10-22 18:15 ` Ranjit Menon
2020-10-22 19:05 ` Dmitry Kozlyuk
2020-10-26 19:01   ` Kadam, Pallavi
2020-10-26 18:44 ` [dpdk-dev] [PATCH v2] eal: enable windows apps to run on non-admin users Pallavi Kadam
2020-10-27 23:10   ` Dmitry Kozlyuk [this message]
2020-10-28 12:41   ` Burakov, Anatoly
2020-11-03 20:28     ` Thomas Monjalon
2020-10-29 18:37   ` Narcisa Ana Maria Vasile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201028021020.0d5a5441@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=Narcisa.Vasile@microsoft.com \
    --cc=dev@dpdk.org \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git