From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C211EA04B5;
	Wed, 28 Oct 2020 00:10:26 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 279EE2BF7;
	Wed, 28 Oct 2020 00:10:25 +0100 (CET)
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id CCB352BF5
 for <dev@dpdk.org>; Wed, 28 Oct 2020 00:10:23 +0100 (CET)
Received: by mail-lj1-f196.google.com with SMTP id c21so3733768ljj.0
 for <dev@dpdk.org>; Tue, 27 Oct 2020 16:10:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=44vTKuNHXFp+c1LfqFSpVyHv5uOx348/T1iU7Vzxiwg=;
 b=qJFcT8xwL42GwEV+9vGmmnUCAB9NkRwgztvUYX+RlIx8Dolj8mwgTA9S3pbbtpzlZy
 O9Fc5VWaGmSbXHZsqMseIeSqIBW8lC9KSAiOTuQ6RPQm80vmAx4tSV94oU5D2s62RNcs
 tfIbcOdaGVMrWMWmbiAmYQi98SSFiKlwrqrTB9rdAzJZX4ffdhI+YSkUJHaJrSnmy8rv
 Ubyyan5+c0j4bYFtmrqeviwITZEOPU3qbipZU0fgru40urdt34g7sBb0tARm7L0/k4Hm
 rNh/MbRs+d3OjtZyoiOgjyZDhf+vFRrb8WxXqUArb1DrGkG21Tzc50mW3PyuqRwEHKD5
 rZnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=44vTKuNHXFp+c1LfqFSpVyHv5uOx348/T1iU7Vzxiwg=;
 b=plHVRfIUlnQXKZOqZasU1vke/i+lI3A2tdyevGzzsmWyxN1bddG1yA4d46orPh05eE
 zeDuUSxo1vUMEaN2zi8psRFxoJlQlBkAIYBkmDBFAektn8nS8s1Jhxd+65UEiE3RZH6H
 Z3NTzMQizrcFh4dz6zEPYe5CqNYZ0dMhm02uKJvMoir6R+jLDbSUvQbwYLlY40Zzuxxm
 9PLKVp9aa5kz7Sjek+jM0IoNSs0i7G0/lHt9b+YUa3yD0vpX+A/BD47Tb0O7bG08aEub
 GGeYUFBN/ujgag30v1L8MSL+6gg/coof7E+CL+Ev1xzFt7kMM+01dCpkBGGfIh5YDUrs
 aFRQ==
X-Gm-Message-State: AOAM530O7Fvc0iOr/AksQo+VPO/6yQuJp+4mK1hrzYjzMw0et+/9C8Il
 nRdG15c/CfOWay9TFYp/5bw=
X-Google-Smtp-Source: ABdhPJxsvv5hxTsgsJixYN/rzfP9OabvA1270MPC6YHTTcKhfK/th/+GepSQkPyk/A/TQmv8LqNR5A==
X-Received: by 2002:a2e:9f4d:: with SMTP id v13mr2122325ljk.379.1603840222341; 
 Tue, 27 Oct 2020 16:10:22 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id h20sm318273lfc.264.2020.10.27.16.10.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 27 Oct 2020 16:10:21 -0700 (PDT)
Date: Wed, 28 Oct 2020 02:10:20 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com,
 Narcisa.Vasile@microsoft.com, talshn@nvidia.com
Message-ID: <20201028021020.0d5a5441@sovereign>
In-Reply-To: <20201026184458.8492-1-pallavi.kadam@intel.com>
References: <20201021202616.2732-1-pallavi.kadam@intel.com>
 <20201026184458.8492-1-pallavi.kadam@intel.com>
X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] eal: enable windows apps to run on
	non-admin users
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 26 Oct 2020 11:44:58 -0700, Pallavi Kadam wrote:
> Currently, since there is no runtime directory set, the code tries to
> create a file in C:\ which is only writable with administrator
> privileges. As a result, if the user is not admin, the application will
> fail.
> So, forcing no_shconf to 1 to prevent the code having to create files in
> the runtime directory.
> 
> Suggested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
>  lib/librte_eal/windows/eal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c
> index 6334aca03..105549de1 100644
> --- a/lib/librte_eal/windows/eal.c
> +++ b/lib/librte_eal/windows/eal.c
> @@ -295,6 +295,7 @@ rte_eal_init(int argc, char **argv)
>  		RTE_LOG(WARNING, EAL, "Multi-process support is requested, "
>  			"but not available.\n");
>  		internal_conf->in_memory = 1;
> +		internal_conf->no_shconf = 1;
>  	}
>  
>  	if (!internal_conf->no_hugetlbfs && (eal_hugepage_info_init() < 0)) {

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>