From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 000CCA04DD; Wed, 28 Oct 2020 15:43:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69524CB3E; Wed, 28 Oct 2020 15:43:58 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D885ACB2E for ; Wed, 28 Oct 2020 15:43:56 +0100 (CET) IronPort-SDR: 6uNIOPUzsxsOOuJA2vOSaZA4BZpNjOL3jMNJwOJV3Nadh58wM8KjhxPWPIaQeIZeJCdiG+3brO taIifngpgj5A== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="232449340" X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="232449340" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 07:43:54 -0700 IronPort-SDR: dPLbKRgAvwyci3s5NkjwMfFIvhtC+wbuQ7J1tynRODyvcnOgjC+xNWa99W15L4WpxA1I6eebx5 H4e8PwwFx2Hg== X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="526352866" Received: from bricha3-mobl.ger.corp.intel.com ([10.255.205.158]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Oct 2020 07:43:50 -0700 Date: Wed, 28 Oct 2020 14:43:45 +0000 From: Bruce Richardson To: Juraj =?utf-8?Q?Linke=C5=A1?= Cc: Ruifeng.Wang@arm.com, Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com, Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com, dev@dpdk.org Message-ID: <20201028144345.GA1634@bricha3-MOBL.ger.corp.intel.com> References: <1603464488-25493-1-git-send-email-juraj.linkes@pantheon.tech> <1603893845-5736-1-git-send-email-juraj.linkes@pantheon.tech> <1603893845-5736-2-git-send-email-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1603893845-5736-2-git-send-email-juraj.linkes@pantheon.tech> Subject: Re: [dpdk-dev] [PATCH v5 01/11] build: alias default build as generic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 03:03:55PM +0100, Juraj Linkeš wrote: > The current machine='default' build name is not descriptive. The actual > default build is machine='native'. Add an alternative string which does > the same build and better describes what we're building: > machine='generic'. Leave machine='default' for backwards compatibility. > > Signed-off-by: Juraj Linkeš > --- Looks good generally. Only suggestion is that the comment for the "machine" value in meson_options.txt needs to be expanded and should describe "generic" and "native" options. Did you check for any documentation updates that may be needed for this? > config/arm/meson.build | 5 +++-- > config/meson.build | 9 +++++---- > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index b49203fa8..4fd32f0ca 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -1,12 +1,13 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation. > # Copyright(c) 2017 Cavium, Inc > +# Copyright(c) 2020 PANTHEON.tech s.r.o. > > # for checking defines we need to use the correct compiler flags > march_opt = '-march=@0@'.format(machine) > > arm_force_native_march = false > -arm_force_default_march = (machine == 'default') > +arm_force_generic_march = (machine == 'generic') > > flags_common_default = [ > # Accelarate rte_memcpy. Be sure to run unit test (memcpy_perf_autotest) > @@ -145,7 +146,7 @@ else > cmd_generic = ['generic', '', '', 'default', ''] > cmd_output = cmd_generic # Set generic by default > machine_args = [] # Clear previous machine args > - if arm_force_default_march and not meson.is_cross_build() > + if arm_force_generic_march and not meson.is_cross_build() > machine = impl_generic > impl_pn = 'default' > elif not meson.is_cross_build() > diff --git a/config/meson.build b/config/meson.build > index 258b01d06..c7f7aa6e2 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -68,13 +68,14 @@ else > machine = get_option('machine') > endif > > -# machine type 'default' is special, it defaults to the per arch agreed common > -# minimal baseline needed for DPDK. > +# machine type 'generic' is special, it defaults to the per arch agreed common > +# minimal baseline needed for DPDK. Machine type 'default' is also supported > +# with the same meaning for backwards compatibility. > # That might not be the most optimized, but the most portable version while > # still being able to support the CPU features required for DPDK. > # This can be bumped up by the DPDK project, but it can never be an > # invariant like 'native' > -if machine == 'default' > +if machine == 'default' or machine == 'generic' > if host_machine.cpu_family().startswith('x86') > # matches the old pre-meson build systems default > machine = 'corei7' > @@ -82,7 +83,7 @@ if machine == 'default' > machine = 'armv7-a' > elif host_machine.cpu_family().startswith('aarch') > # arm64 manages defaults in config/arm/meson.build > - machine = 'default' > + machine = 'generic' > elif host_machine.cpu_family().startswith('ppc') > machine = 'power8' > endif > -- > 2.20.1 >