From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D424AA04DD; Wed, 28 Oct 2020 17:33:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A990972E2; Wed, 28 Oct 2020 17:33:05 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4D9F93976 for ; Wed, 28 Oct 2020 17:33:04 +0100 (CET) IronPort-SDR: 7Nr7wSNaKOfUyQsL9T94/4nuJ93Lh4AtRyUfxe9H3UKWOooqmtcYkkOGJCRZ7D/mBjI+MuZB0K DM8h4/QZjiIQ== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="164790043" X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="164790043" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 09:33:02 -0700 IronPort-SDR: 1fA+lDA7s/YcDd1f5kpUELjP0ct79ucMKux+biJRPJfYFpMMwsLHJS/aRwnmUtxTw/0ZpH/NuL /J6sK2yi7Wcw== X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="468792733" Received: from bricha3-mobl.ger.corp.intel.com ([10.255.205.158]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Oct 2020 09:32:59 -0700 Date: Wed, 28 Oct 2020 16:32:54 +0000 From: Bruce Richardson To: dev@dpdk.org Cc: Ma Lihong , Hemant Agrawal Message-ID: <20201028163254.GE1634@bricha3-MOBL.ger.corp.intel.com> References: <20200825114447.135030-1-bruce.richardson@intel.com> <20200903144942.671870-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903144942.671870-1-bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 03, 2020 at 03:49:39PM +0100, Bruce Richardson wrote: > A number of the more advanced DPDK build settings which are not expected to > be user modified are stored in config/rte_config.h. In some cases, for a > custom build a user may want to override those settings via CFLAGS, so we > need to ensure that the definitions do not override the user-provided > values. > > Bruce Richardson (3): > config: remove explicit undefinition of unset values > config: allow overriding some build defaults > doc: add notes on overriding extra config values Since there are issues flagged on this set, and I don't have a good solution to fix them right now, I think the best approach is to drop this set for consideration for merging in 20.11 release. As such, I'm going to mark this set as rejected in patchwork. If we still have a problem here in future, we can look at this again, but I don't see the current patchset going ahead in its current form. Regards, /Bruce