From: Ibtisam Tariq <ibtisam.tariq@emumba.com> To: marko.kovacevic@intel.com, konstantin.ananyev@intel.com, reshma.pattan@intel.com, john.mcnamara@intel.com, cristian.dumitrescu@intel.com, jasvinder.singh@intel.com, chenbo.xia@intel.com, maxime.coquelin@redhat.com, xiaoyun.li@intel.com Cc: dev@dpdk.org, Ibtisam Tariq <ibtisam.tariq@emumba.com>, sergio.gonzalez.monroy@intel.com, phil.yang@arm.com Subject: [dpdk-dev] [PATCH 3/8] examples/packet_ordering: enhance getopt_long usage Date: Thu, 29 Oct 2020 12:53:34 +0000 Message-ID: <20201029125339.30916-3-ibtisam.tariq@emumba.com> (raw) In-Reply-To: <20201029125339.30916-1-ibtisam.tariq@emumba.com> Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. Bugzilla ID: 238 Fixes: 850f3733f8 ("examples/packet_ordering: new sample app") Fixes: 016493307a ("examples/packet_ordering: add stats per worker thread") Cc: sergio.gonzalez.monroy@intel.com Cc: phil.yang@arm.com Reported-by: David Marchand <david.marchand@redhat.com> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com> --- examples/packet_ordering/main.c | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index a79d77a32..ac41d1a88 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c @@ -29,6 +29,13 @@ /* Macros for printing using RTE_LOG */ #define RTE_LOGTYPE_REORDERAPP RTE_LOGTYPE_USER1 +enum{ +#define OPTION_DISABLE_REORDER "disable-reorder" + OPTION_DISABLE_REORDER_NUM = 256, +#define OPTION_INSIGHT_WORKER "insight-worker" + OPTION_INSIGHT_WORKER_NUM, +}; + unsigned int portmask; unsigned int disable_reorder; unsigned int insight_worker; @@ -157,8 +164,8 @@ parse_args(int argc, char **argv) char **argvopt; char *prgname = argv[0]; static struct option lgopts[] = { - {"disable-reorder", 0, 0, 0}, - {"insight-worker", 0, 0, 0}, + {OPTION_DISABLE_REORDER, 0, NULL, OPTION_DISABLE_REORDER_NUM}, + {OPTION_INSIGHT_WORKER, 0, NULL, OPTION_INSIGHT_WORKER_NUM}, {NULL, 0, 0, 0} }; @@ -177,17 +184,18 @@ parse_args(int argc, char **argv) } break; /* long options */ - case 0: - if (!strcmp(lgopts[option_index].name, "disable-reorder")) { - printf("reorder disabled\n"); - disable_reorder = 1; - } - if (!strcmp(lgopts[option_index].name, - "insight-worker")) { - printf("print all worker statistics\n"); - insight_worker = 1; - } + case OPTION_DISABLE_REORDER_NUM: + { + printf("reorder disabled\n"); + disable_reorder = 1; break; + } + case OPTION_INSIGHT_WORKER_NUM: + { + printf("print all worker statistics\n"); + insight_worker = 1; + break; + } default: print_usage(prgname); return -1; -- 2.17.1
next prev parent reply other threads:[~2020-10-29 12:56 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-29 12:53 [dpdk-dev] [PATCH 1/8] examples/fips_validation: " Ibtisam Tariq 2020-10-29 12:53 ` [dpdk-dev] [PATCH 2/8] examples/l3fwd-acl: " Ibtisam Tariq 2020-10-29 12:53 ` Ibtisam Tariq [this message] 2020-10-29 12:53 ` [dpdk-dev] [PATCH 4/8] examples/performance-thread/l3fwd-thread: " Ibtisam Tariq 2020-10-29 12:53 ` [dpdk-dev] [PATCH 5/8] examples/qos_sched: " Ibtisam Tariq 2020-10-29 12:53 ` [dpdk-dev] [PATCH 6/8] examples/vhost: " Ibtisam Tariq 2020-10-29 12:53 ` [dpdk-dev] [PATCH 7/8] examples/vhost_crypto: " Ibtisam Tariq 2020-10-29 12:53 ` [dpdk-dev] [PATCH 8/8] examples/tep_termination: " Ibtisam Tariq 2020-10-29 13:16 ` David Marchand 2020-11-02 8:18 ` Ibtisam Tariq 2020-10-29 22:07 ` [dpdk-dev] [PATCH 1/8] examples/fips_validation: " David Marchand 2020-11-02 8:32 ` Ibtisam Tariq 2020-11-04 10:00 ` Ibtisam Tariq 2020-11-05 8:59 ` David Marchand 2020-11-10 6:10 ` Ibtisam Tariq 2020-11-10 8:23 ` David Marchand 2020-11-10 9:03 ` Ibtisam Tariq
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201029125339.30916-3-ibtisam.tariq@emumba.com \ --to=ibtisam.tariq@emumba.com \ --cc=chenbo.xia@intel.com \ --cc=cristian.dumitrescu@intel.com \ --cc=dev@dpdk.org \ --cc=jasvinder.singh@intel.com \ --cc=john.mcnamara@intel.com \ --cc=konstantin.ananyev@intel.com \ --cc=marko.kovacevic@intel.com \ --cc=maxime.coquelin@redhat.com \ --cc=phil.yang@arm.com \ --cc=reshma.pattan@intel.com \ --cc=sergio.gonzalez.monroy@intel.com \ --cc=xiaoyun.li@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git