DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev]  test: fix GMAC SGL test
@ 2020-10-29 14:43 Fan Zhang
  2020-10-29 14:46 ` [dpdk-dev] [dpdk-dev v2] " Fan Zhang
  0 siblings, 1 reply; 5+ messages in thread
From: Fan Zhang @ 2020-10-29 14:43 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, Fan Zhang, pablo.de.lara.guarch

This ptach fixes the GMAC SGL test that fails to bypass
unsupported PMDs.

Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
Cc: pablo.de.lara.guarch@intel.com

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 0fed124d3..130719d67 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const struct gmac_test_data *tdata,
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 	feature_flags = dev_info.feature_flags;
 
-	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
-			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
+	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
+			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
 			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
 		return -ENOTSUP;
 
-- 
2.26.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test
  2020-10-29 14:43 [dpdk-dev] test: fix GMAC SGL test Fan Zhang
@ 2020-10-29 14:46 ` Fan Zhang
  2020-10-30  2:16   ` Jiang, YuX
  2020-11-03 12:54   ` De Lara Guarch, Pablo
  0 siblings, 2 replies; 5+ messages in thread
From: Fan Zhang @ 2020-10-29 14:46 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, Fan Zhang, pablo.de.lara.guarch

This patch fixes the GMAC SGL test that fails to bypass
unsupported PMDs.

Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
Cc: pablo.de.lara.guarch@intel.com

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
v2:
- fix typo
 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 0fed124d3..130719d67 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const struct gmac_test_data *tdata,
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 	feature_flags = dev_info.feature_flags;
 
-	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
-			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
+	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
+			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
 			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
 		return -ENOTSUP;
 
-- 
2.26.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test
  2020-10-29 14:46 ` [dpdk-dev] [dpdk-dev v2] " Fan Zhang
@ 2020-10-30  2:16   ` Jiang, YuX
  2020-11-03 12:54   ` De Lara Guarch, Pablo
  1 sibling, 0 replies; 5+ messages in thread
From: Jiang, YuX @ 2020-10-30  2:16 UTC (permalink / raw)
  To: Zhang, Roy Fan, dev, Jiang, YuX
  Cc: akhil.goyal, Zhang, Roy Fan, De Lara Guarch, Pablo

Tested-by: JiangYuX <yux.jiang@intel.com>

    Best Regards
    Jiang yu


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Thursday, October 29, 2020 10:47 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test
> 
> This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
> 
> Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> Cc: pablo.de.lara.guarch@intel.com
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> v2:
> - fix typo
>  app/test/test_cryptodev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 0fed124d3..130719d67 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const
> struct gmac_test_data *tdata,
>  	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
>  	feature_flags = dev_info.feature_flags;
> 
> -	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
> -			(!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
> +	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
> +			(!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
>  			(!(feature_flags &
> RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
>  		return -ENOTSUP;
> 
> --
> 2.26.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test
  2020-10-29 14:46 ` [dpdk-dev] [dpdk-dev v2] " Fan Zhang
  2020-10-30  2:16   ` Jiang, YuX
@ 2020-11-03 12:54   ` De Lara Guarch, Pablo
  2020-11-04  7:07     ` Akhil Goyal
  1 sibling, 1 reply; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2020-11-03 12:54 UTC (permalink / raw)
  To: Zhang, Roy Fan, dev; +Cc: akhil.goyal



> -----Original Message-----
> From: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Sent: Thursday, October 29, 2020 2:47 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev v2] test: fix GMAC SGL test
> 
> This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
> 
> Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> Cc: pablo.de.lara.guarch@intel.com
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

Commit message can be changed to "test/crypto: fix GMAC SGL", but I think it can be changed when applying the patch.

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test
  2020-11-03 12:54   ` De Lara Guarch, Pablo
@ 2020-11-04  7:07     ` Akhil Goyal
  0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2020-11-04  7:07 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, Zhang, Roy Fan, dev

> > Subject: [dpdk-dev v2] test: fix GMAC SGL test
> >
> > This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.
> >
> > Fixes: dcdd01691f39 ("test/crypto: add GMAC SGL")
> > Cc: pablo.de.lara.guarch@intel.com
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> 
> Commit message can be changed to "test/crypto: fix GMAC SGL", but I think it
> can be changed when applying the patch.
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-04  7:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-29 14:43 [dpdk-dev] test: fix GMAC SGL test Fan Zhang
2020-10-29 14:46 ` [dpdk-dev] [dpdk-dev v2] " Fan Zhang
2020-10-30  2:16   ` Jiang, YuX
2020-11-03 12:54   ` De Lara Guarch, Pablo
2020-11-04  7:07     ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git