DPDK patches and discussions
 help / color / mirror / Atom feed
From: Michal Krawczyk <mk@semihalf.com>
To: dev@dpdk.org
Cc: mw@semihalf.com, igorch@amazon.com, gtzalik@amazon.com,
	Michal Krawczyk <mk@semihalf.com>,
Subject: [dpdk-dev] [PATCH 1/6] net/ena: fix getting xstats global stats offset
Date: Fri, 30 Oct 2020 12:31:16 +0100
Message-ID: <20201030113121.1310305-2-mk@semihalf.com> (raw)
In-Reply-To: <20201030113121.1310305-1-mk@semihalf.com>

There was a bug in a code, which was reading stat_offset value from the
ena_stats_rx_strings array instead of ena_stats_global_strings.

It wasn't causing real problems just because ena_stats_rx_strings was
not smaller than ena_stats_global_strings and both arrays hold the same

Fixes: 7830e905b7c9 ("net/ena: expose extended stats")
Cc: stable@dpdk.org

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@amazon.com>
Reviewed-by: Guy Tzalik <gtzalik@amazon.com>
 drivers/net/ena/ena_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index c513faf202..7ab9b93ba9 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2724,7 +2724,7 @@ static int ena_xstats_get(struct rte_eth_dev *dev,
 		return 0;
 	for (stat = 0; stat < ENA_STATS_ARRAY_GLOBAL; stat++, count++) {
-		stat_offset = ena_stats_rx_strings[stat].stat_offset;
+		stat_offset = ena_stats_global_strings[stat].stat_offset;
 		stats_begin = &adapter->dev_stats;
 		xstats[count].id = count;

  reply	other threads:[~2020-10-30 11:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 11:31 [dpdk-dev] [PATCH 0/6] net/ena: fixes and missing version/doc udate Michal Krawczyk
2020-10-30 11:31 ` Michal Krawczyk [this message]
2020-10-30 11:31 ` [dpdk-dev] [PATCH 2/6] net/ena: fix setting Rx checksum flags in mbuf Michal Krawczyk
2020-10-30 11:31 ` [dpdk-dev] [PATCH 3/6] net/ena: change name of the supported PCI device IDs Michal Krawczyk
2020-10-30 11:31 ` [dpdk-dev] [PATCH 4/6] net/ena/base: align IO cq allocation to a 4K Michal Krawczyk
2020-10-30 11:31 ` [dpdk-dev] [PATCH 5/6] doc: mark ARMv8 as supported by ENA PMD Michal Krawczyk
2020-10-30 11:31 ` [dpdk-dev] [PATCH 6/6] net/ena: upgrade driver version to v2.2.0 Michal Krawczyk
2020-10-30 23:48 ` [dpdk-dev] [PATCH 0/6] net/ena: fixes and missing version/doc udate Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030113121.1310305-2-mk@semihalf.com \
    --to=mk@semihalf.com \
    --cc=dev@dpdk.org \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=mw@semihalf.com \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git