From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1536A04DE; Fri, 30 Oct 2020 16:37:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B1FE7C9C6; Fri, 30 Oct 2020 16:37:08 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 27308C9BE for ; Fri, 30 Oct 2020 16:37:05 +0100 (CET) IronPort-SDR: w8mp9ooZgoDv5j+ND245P2Hd6C1qT+7LJbxdSKvJC0aUrGkjeVVdTsKDnTMqSMf3HjT37OOY4d ztbPr4jEK/Sg== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="147908747" X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="147908747" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 08:37:04 -0700 IronPort-SDR: nOLQYly1mBX/16+B8RbVn8ireI+Lb4vgZ2bND1jY2lXDbrVY2Oq1CnVbHO+Q5NIpUwH1HtIrPa W7JDLvUj4bjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="351895384" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.223.148]) by fmsmga004.fm.intel.com with ESMTP; 30 Oct 2020 08:37:02 -0700 From: Ciara Power To: dev@dpdk.org Cc: david.marchand@redhat.com, Ciara Power , roy.fan.zhang@intel.com, Marko Kovacevic Date: Fri, 30 Oct 2020 15:37:00 +0000 Message-Id: <20201030153700.267200-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201028153808.103328-1-ciara.power@intel.com> References: <20201028153808.103328-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] examples/fips_validation: fix checking return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The return value was not being checked when calling the get_writeback_data function in the AES test case. On failure, this led to a NULL dereference when using memcpy later. The return value is now checked to avoid this NULL dereference. Coverity issue: 363463 Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list") Cc: roy.fan.zhang@intel.com Signed-off-by: Ciara Power --- v2: - Fixed incorrect "Fixes" tag. - Added same fix to another test case. --- examples/fips_validation/main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 07532c9562..6a1cea36f5 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -1520,7 +1520,9 @@ fips_mct_aes_test(void) return ret; } - get_writeback_data(&val); + ret = get_writeback_data(&val); + if (ret < 0) + return ret; if (info.op == FIPS_TEST_DEC_AUTH_VERIF) memcpy(prev_in, vec.ct.val, AES_BLOCK_SIZE); @@ -1649,7 +1651,9 @@ fips_mct_sha_test(void) return ret; } - get_writeback_data(&val); + ret = get_writeback_data(&val); + if (ret < 0) + return ret; memcpy(md[0].val, md[1].val, md[1].len); md[0].len = md[1].len; -- 2.25.1