From: Ciara Power <ciara.power@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, Ciara Power <ciara.power@intel.com>,
roy.fan.zhang@intel.com,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: [dpdk-dev] [PATCH v2] examples/fips_validation: fix resource leak on failure
Date: Fri, 30 Oct 2020 17:36:40 +0000 [thread overview]
Message-ID: <20201030173641.374525-1-ciara.power@intel.com> (raw)
In-Reply-To: <20201028155327.104488-1-ciara.power@intel.com>
The wb_data variable went out of scope on failure in the
get_writeback_data function. This is now freed before returning -1.
Coverity issue: 363453
Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list")
Cc: roy.fan.zhang@intel.com
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
v2: Fixed incorrect pointer used in free.
---
examples/fips_validation/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 07532c9562..b37eb41c0d 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1128,6 +1128,7 @@ get_writeback_data(struct fips_val *val)
if (data_len) {
RTE_LOG(ERR, USER1, "Error -1: write back data\n");
+ free(wb_data);
return -1;
}
--
2.25.1
next prev parent reply other threads:[~2020-10-30 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 15:53 [dpdk-dev] [PATCH] " Ciara Power
2020-10-30 13:08 ` David Marchand
2020-10-30 17:36 ` Ciara Power [this message]
2020-10-31 17:09 ` [dpdk-dev] [PATCH v2] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030173641.374525-1-ciara.power@intel.com \
--to=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).