From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0DEA9A04E7;
Sun, 1 Nov 2020 19:06:59 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 276892BF9;
Sun, 1 Nov 2020 19:06:42 +0100 (CET)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C87222BDB
for <dev@dpdk.org>; Sun, 1 Nov 2020 19:06:39 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 764965C0097;
Sun, 1 Nov 2020 13:06:38 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Sun, 01 Nov 2020 13:06:38 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding; s=fm2; bh=d3ztsAyXOIJYQ
l5EkxV8lcANpMnAVb2RCdS4o479Bec=; b=V+ua7lJfiXqxpDg+0BQ643TijrmdS
j37bsTxc1Iu4ggz0R5oxYqwCATERuR0xhcc/q1ykMV550vo04YBkegJAwxbwdkiH
kU43RuLPGFQ+odBGKZ16ZJirh5xy7m6FtgvIXQpMYx4O7+AKCSvp1U0K/gPTSWNN
TWHy4qXw+OdS4Q8xk+40lB3l5UD+AUXrRTzKpxZgC2Sr20n+kZ2773EELb+LfXFx
Mt+Zsb7SnR9EvBi3TLMPdZx63o5mJ4dA+lGJPsUU759x/9EwxfOXsr+hYGiJTj5z
Fenkgp3Ad60Q2iSS3in+GkOaU6lxu4mh91eP6M2+HVZadltzcgfZbf7yA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:date:from
:in-reply-to:message-id:mime-version:references:subject:to
:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm1; bh=d3ztsAyXOIJYQl5EkxV8lcANpMnAVb2RCdS4o479Bec=; b=Iy672/3y
g2g3USUU9HfJeADq/m+W5oPJGt+9rR5RdcMaugZzni3pVv2b2rInkzbYMoVjc9N8
6T8pdZqob8MocBfL0667zB3HLQwbbC+aej1Ih/pb77HoZtC1RUJJc8//v4MJTNO8
AetzJ8nmu6SOqGNB+0SbfsZxpVWfhkSHSCRsoaYiiLQaF8cQtzx7tC3fCT+za+W5
HHSf1oyEfIi6j0iFH8BYZCDj1UChXovNQlqpzDxCA1k7O0W9b3+rQuch0viDeIGb
pZLj3NMlr3SOCVKXro6ouKH7q6/yq+XWrUsOp9HO5P8SSmSZr9j/It4ihdg4wD97
hP0PflOussY2qw==
X-ME-Sender: <xms:LvmeX0aUV8EpgG_wvAQVjB3YxqGZ3UBfwEoboC12eNgHHzGSxo78MA>
<xme:LvmeX_Yh_60qjObJdlt__vj5lH5pnZVfBO7fZ1P6ma1WDyt4aXF_zA3z43zQS_sIn
_8n3dFbqKeO4f_6Xw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleelgdduuddvucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg
uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:LvmeX-_RTOgiAT7xRwQHNUml75S_lq024tX85dQuosYBhVWlWq-K4Q>
<xmx:LvmeX-qIifxulLugM0cZdEr2h04_RPiF2IYB8bWQ5HY6jl4IKgoi0A>
<xmx:LvmeX_pLjXdhpu_lXO3iANP9a2LmFLl7wMiOisf15JpRKYTtBpOKIg>
<xmx:LvmeXweXiuEqTu0hnAhLb7BzuL57BbcHtNijzJd4ob-1DmpJclszUg>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 556F73280063;
Sun, 1 Nov 2020 13:06:37 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, david.marchand@redhat.com,
bruce.richardson@intel.com, olivier.matz@6wind.com,
andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com,
Nikhil Rao <nikhil.rao@intel.com>
Date: Sun, 1 Nov 2020 19:06:13 +0100
Message-Id: <20201101180626.2198868-2-thomas@monjalon.net>
X-Mailer: git-send-email 2.28.0
In-Reply-To: <20201101180626.2198868-1-thomas@monjalon.net>
References: <20201029092751.3837177-1-thomas@monjalon.net>
<20201101180626.2198868-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v2 01/14] eventdev: remove software Rx timestamp
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
This a revert of the commit 569758758dcd ("eventdev: add Rx timestamp").
If the Rx timestamp is not configured on the ethdev port,
there is no reason to set one.
Also the accuracy of the timestamp was bad because set at a late stage.
Anyway there is no trace of the usage of this timestamp.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/prog_guide/event_ethernet_rx_adapter.rst | 6 +-----
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 11 -----------
lib/librte_eventdev/rte_event_eth_rx_adapter.h | 6 +-----
3 files changed, 2 insertions(+), 21 deletions(-)
diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
index 236f43f455..cb44ce0e47 100644
--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
@@ -12,11 +12,7 @@ be supported in hardware or require a software thread to receive packets from
the ethdev port using ethdev poll mode APIs and enqueue these as events to the
event device using the eventdev API. Both transfer mechanisms may be present on
the same platform depending on the particular combination of the ethdev and
-the event device. For SW based packet transfer, if the mbuf does not have a
-timestamp set, the adapter adds a timestamp to the mbuf using
-rte_get_tsc_cycles(), this provides a more accurate timestamp as compared to
-if the application were to set the timestamp since it avoids event device
-schedule latency.
+the event device.
The Event Ethernet Rx Adapter library is intended for the application code to
configure both transfer mechanisms using a common API. A capability API allows
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index f0000d1ede..3c73046551 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -763,7 +763,6 @@ rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_adapter,
uint32_t rss_mask;
uint32_t rss;
int do_rss;
- uint64_t ts;
uint16_t nb_cb;
uint16_t dropped;
@@ -771,16 +770,6 @@ rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_adapter,
rss_mask = ~(((m->ol_flags & PKT_RX_RSS_HASH) != 0) - 1);
do_rss = !rss_mask && !eth_rx_queue_info->flow_id_mask;
- if ((m->ol_flags & PKT_RX_TIMESTAMP) == 0) {
- ts = rte_get_tsc_cycles();
- for (i = 0; i < num; i++) {
- m = mbufs[i];
-
- m->timestamp = ts;
- m->ol_flags |= PKT_RX_TIMESTAMP;
- }
- }
-
for (i = 0; i < num; i++) {
m = mbufs[i];
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
index 2dd259c279..21bb1e54c8 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
@@ -21,11 +21,7 @@
*
* The adapter uses a EAL service core function for SW based packet transfer
* and uses the eventdev PMD functions to configure HW based packet transfer
- * between the ethernet device and the event device. For SW based packet
- * transfer, if the mbuf does not have a timestamp set, the adapter adds a
- * timestamp to the mbuf using rte_get_tsc_cycles(), this provides a more
- * accurate timestamp as compared to if the application were to set the time
- * stamp since it avoids event device schedule latency.
+ * between the ethernet device and the event device.
*
* The ethernet Rx event adapter's functions are:
* - rte_event_eth_rx_adapter_create_ext()
--
2.28.0