DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/iavf: fix invalid RSS type
@ 2020-10-30  3:16 Simei Su
  2020-10-30  9:41 ` Zhang, Qi Z
  2020-11-02  2:04 ` [dpdk-dev] [PATCH v2] " Simei Su
  0 siblings, 2 replies; 7+ messages in thread
From: Simei Su @ 2020-10-30  3:16 UTC (permalink / raw)
  To: qi.z.zhang; +Cc: dev, jia.guo, junfeng.guo, Simei Su

When a RSS rule with symmetric hash function, the RSS type shouldn't
carry with SRC/DST_ONLY. This patch adds invalid RSS type check for
the case.

Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")

Signed-off-by: Simei Su <simei.su@intel.com>
---
 drivers/net/iavf/iavf_hash.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index be821b6..6d0360a 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -917,6 +917,22 @@ iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,
 			 */
 			rss_type = rte_eth_rss_hf_refine(rss_type);
 
+			/**
+			 * Check if SRC/DST_ONLY is set for SYMMETRIC_TOEPLITZ
+			 * hash function.
+			 */
+			if (rss->func ==
+			    RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {
+				if (rss_type & ((VALID_RSS_ATTR &
+				    ~RTE_ETH_RSS_L3_PRE64) |
+				    ~(VALID_RSS_IPV4 | VALID_RSS_IPV6)))
+					return rte_flow_error_set(error,
+						ENOTSUP,
+						RTE_FLOW_ERROR_TYPE_ACTION,
+						action,
+						"invalid rss types");
+			}
+
 			if (iavf_any_invalid_rss_type(rss_type,
 					match_item->input_set_mask))
 				return rte_flow_error_set(error, ENOTSUP,
-- 
2.9.5


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-11-02 12:18 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30  3:16 [dpdk-dev] [PATCH] net/iavf: fix invalid RSS type Simei Su
2020-10-30  9:41 ` Zhang, Qi Z
2020-11-02  2:11   ` Su, Simei
2020-11-02  2:04 ` [dpdk-dev] [PATCH v2] " Simei Su
2020-11-02 11:39   ` [dpdk-dev] [PATCH v3] " Simei Su
2020-11-02 11:55     ` [dpdk-dev] [PATCH v4] " Simei Su
2020-11-02 12:18       ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git