From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 561D2A04E7; Mon, 2 Nov 2020 18:34:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 526E32C15; Mon, 2 Nov 2020 18:34:11 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 167A22BD5; Mon, 2 Nov 2020 18:34:07 +0100 (CET) IronPort-SDR: e7gbzP4kPwFfiXvyowu3AWSu5qWlQ2UcDuE6688JpnSLH/nRVeh75fX5uwReg0ew5XgvB+rNZz Dy3iNgg6EePg== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="168139004" X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="168139004" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 09:34:06 -0800 IronPort-SDR: f43xGZwDw55t/dJRr5kjhr2KMREfzwSbHfzWFiW/HGfTeiTItQKpdrheBSVAOp9Z0mgFY0N4lY 0z0dDofZIzlQ== X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="538103406" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.49.238]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Nov 2020 09:34:03 -0800 Date: Mon, 2 Nov 2020 17:33:59 +0000 From: Bruce Richardson To: Dharmik Thakkar Cc: Vladimir Medvedkin , Honnappa Nagarahalli , Ruifeng Wang , Gavin Hu , dev , nd , dpdk stable Message-ID: <20201102173359.GE1454@bricha3-MOBL.ger.corp.intel.com> References: <20201029153634.10647-1-dharmik.thakkar@arm.com> <20201102151157.GD1454@bricha3-MOBL.ger.corp.intel.com> <6F792248-5555-4831-AFA3-9D839770B37D@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6F792248-5555-4831-AFA3-9D839770B37D@arm.com> Subject: Re: [dpdk-dev] [PATCH 1/4] test/lpm: fix cycle calculation in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 02, 2020 at 04:58:43PM +0000, Dharmik Thakkar wrote: > > > On Nov 2, 2020, at 9:11 AM, Bruce Richardson wrote: > > > > On Thu, Oct 29, 2020 at 10:36:31AM -0500, Dharmik Thakkar wrote: > >> Fix incorrect calculations for LPM adds, LPM deletes, > >> and average cycles in RCU QSBR perf tests > >> > > > > To help review this patch, could you provide some more details in the > > commit log as to what exactly was wrong with the calculation and how this > > patch fixes things? > > > > I will update the commit message in the next version. Adding it here as well: > > Since, rcu qsbr tests run for ‘RCU_ITERATIONS’ and not ‘ITERATIONS’, > replace ‘ITERATIONS’ with ‘RCU_ITERATIONS’ for calculating adds, deletes, and cycles. > > Also, for multi-writer perf test, each writer only writes half of NUM_LDEPTH_ROUTE_ENTRIES. > For 2 writers, total adds (or deletes) should be (RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES) instead of > (2 * RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES). > > Since, for both the single and multi writer tests, total adds/deletes is equal to (RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES), > this has been replaced with a macro ’TOTAL_WRITES’ and furthermore, ‘g_writes’ has been removed since it is always a fixed value > equal to TOTAL_WRITES. > Thanks for the clear explanation.