From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13C79A04E7; Mon, 2 Nov 2020 19:37:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 228CA2E8F; Mon, 2 Nov 2020 19:36:18 +0100 (CET) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 5D1642E8D for ; Mon, 2 Nov 2020 19:36:16 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id y14so11854257pfp.13 for ; Mon, 02 Nov 2020 10:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=acyheu5Quei1gZLizMaxcGHB0DWJyP2PFS2KjlE0EW8=; b=dPs1P4qpM+RPVN8OsNEaC/KCZfLeBD7+2SjEpA89jnL498L7XH3S/Lx3OOQMk1YApr f4Qa788OiTgKJvdJEt66molTh9IcNAzs1c19B1dDoRWp05tLYlt82AxD5AEVPBcWoVO/ WLZkiHCsDmYxZxDlhcXfaFztg4PeSBofMvUgGWyHd8BHf/ACWK650HBDhRlwVafgDXv3 cYLevYPpsZ7duVJLgozI/wO30PD78s3kYuDz8UHugZjU1mqlAtyjgg0EdgsJRew+mtvN r1wCGTTW9DjqaitChAsC8HgZU/Ir2e/rP6do0SPdy9NrWw40oHIPJQwqSCVfDG7PFl0s wxyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=acyheu5Quei1gZLizMaxcGHB0DWJyP2PFS2KjlE0EW8=; b=OVjLq4yop4VD7elwMGNBlR6mjioa9XBG1XeP6cW/hHddEb98FnA0v44EMS1ZQEO9rw +eKw7J30Yp3BnSWTmfy7PY8/975UKhF4u+b11RLqrkFdkc5xj94DGMaMxMorA29fdAGT Z1ZOR3vQvDn23SShFNZtcFEMMO4Uzhbi+OTpgLI2lnmxpkAeGOeIrp4TYe3YymyXMe4N XgbCiuVWnaE4ZjHeBIZ1AXaoqMXLeZesuyt3QO//ANPdxCr3ChsdXUkfyvOuvn5h4K5X FbTyODaG9S+MtqxQYmxxjQZQxVADrhsuYsz3zA0EUbe8l4QGpuUMSo0fYKnv0691aeFP EK/w== X-Gm-Message-State: AOAM531RTedkIyoCzBCikQIpYXgRwY1h7ChTDP+dauK8zk6RHF/NlzYb 8RzJAaRLakwqnjb0KlEsPUB51zyyEVjq1y22 X-Google-Smtp-Source: ABdhPJzzmpm4e2JrhtAei71x1OgAnv1b9N/qE2yXDhy02lmA8IbaJXvTtkmkbPqE/7CdSSkcH1g7Ug== X-Received: by 2002:a63:70d:: with SMTP id 13mr14717921pgh.263.1604342175384; Mon, 02 Nov 2020 10:36:15 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id s4sm178186pjp.17.2020.11.02.10.36.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2020 10:36:14 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: cardigliano@ntop.org, Andrew Boyer Date: Mon, 2 Nov 2020 10:35:25 -0800 Message-Id: <20201102183527.69209-7-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201102183527.69209-1-aboyer@pensando.io> References: <20201102183527.69209-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH 6/8] ionic: convert 'deferred' boolean to a flag bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This saves space in the structure. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 10 ++++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index bc15d75fd..2e33fb8d9 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -1590,7 +1590,7 @@ ionic_lif_start(struct ionic_lif *lif) for (i = 0; i < lif->nrxqcqs; i++) { struct ionic_qcq *rxq = lif->rxqcqs[i]; - if (!rxq->deferred_start) { + if (!(rxq->flags & IONIC_QCQ_F_DEFERRED)) { err = ionic_dev_rx_queue_start(lif->eth_dev, i); if (err) @@ -1600,7 +1600,7 @@ ionic_lif_start(struct ionic_lif *lif) for (i = 0; i < lif->ntxqcqs; i++) { struct ionic_qcq *txq = lif->txqcqs[i]; - if (!txq->deferred_start) { + if (!(txq->flags & IONIC_QCQ_F_DEFERRED)) { err = ionic_dev_tx_queue_start(lif->eth_dev, i); if (err) diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h index 4e091719f..8e2b42443 100644 --- a/drivers/net/ionic/ionic_lif.h +++ b/drivers/net/ionic/ionic_lif.h @@ -50,6 +50,7 @@ struct ionic_rx_stats { #define IONIC_QCQ_F_SG BIT(1) #define IONIC_QCQ_F_INTR BIT(2) #define IONIC_QCQ_F_NOTIFYQ BIT(3) +#define IONIC_QCQ_F_DEFERRED BIT(4) /* Queue / Completion Queue */ struct ionic_qcq { @@ -68,7 +69,6 @@ struct ionic_qcq { uint32_t total_size; uint32_t flags; struct ionic_intr_info intr; - bool deferred_start; }; #define IONIC_Q_TO_QCQ(q) container_of(q, struct ionic_qcq, q) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 2592f5cab..b953aff49 100644 --- a/drivers/net/ionic/ionic_rxtx.c +++ b/drivers/net/ionic/ionic_rxtx.c @@ -64,7 +64,7 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, qinfo->nb_desc = q->num_descs; qinfo->conf.offloads = txq->offloads; - qinfo->conf.tx_deferred_start = txq->deferred_start; + qinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED; } static inline void __rte_cold @@ -196,7 +196,8 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id, } /* Do not start queue with rte_eth_dev_start() */ - txq->deferred_start = tx_conf->tx_deferred_start; + if (tx_conf->tx_deferred_start) + txq->flags |= IONIC_QCQ_F_DEFERRED; txq->offloads = offloads; @@ -605,7 +606,7 @@ ionic_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, qinfo->mp = rxq->mb_pool; qinfo->scattered_rx = dev->data->scattered_rx; qinfo->nb_desc = q->num_descs; - qinfo->conf.rx_deferred_start = rxq->deferred_start; + qinfo->conf.rx_deferred_start = rxq->flags & IONIC_QCQ_F_DEFERRED; qinfo->conf.offloads = rxq->offloads; } @@ -703,7 +704,8 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev, */ /* Do not start queue with rte_eth_dev_start() */ - rxq->deferred_start = rx_conf->rx_deferred_start; + if (rx_conf->rx_deferred_start) + rxq->flags |= IONIC_QCQ_F_DEFERRED; rxq->offloads = offloads; -- 2.17.1