From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id D3E45A04E7;
Tue, 3 Nov 2020 01:14:48 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E1E364CA6;
Tue, 3 Nov 2020 01:14:29 +0100 (CET)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
[64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 088EC4C7A
for <dev@dpdk.org>; Tue, 3 Nov 2020 01:14:27 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.west.internal (Postfix) with ESMTP id 9F90CB3D;
Mon, 2 Nov 2020 19:14:22 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Mon, 02 Nov 2020 19:14:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding; s=fm2; bh=d3ztsAyXOIJYQ
l5EkxV8lcANpMnAVb2RCdS4o479Bec=; b=nYEV0tqVpC8Y6Th1X0jmeOzy7De5I
fzUyLvDT8BqlJBmANJoANGGp2kmv8YYE1DaRW+rEh2b8YBz9gOCHsTKv5E2v4tax
FGVtWZSaYT5lxCVdhbT+qNv9zOLx/bA2XqdVHtNSfZFekQ0P1r4SnGTrr/5BhVwG
6vVGe8pxydpplQcSp1MEBSgJw9aV4mvAeHZO9u93ySNJG80nWtYD6pKxFJDwuR/n
PLyUz+OT5opVs7+WZNxF/L3nke1fPeFHBN9vlengG53wKLQ/X/nJAWomvF27PVX9
SN+ZRYHKG4kt73yXiBOBL8IamaLd46x5ENnBZeqe4BdNBBnCT1uKHxlBQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:date:from
:in-reply-to:message-id:mime-version:references:subject:to
:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm1; bh=d3ztsAyXOIJYQl5EkxV8lcANpMnAVb2RCdS4o479Bec=; b=LgI/GCNr
PEhYBpPBUmqksTt0c49gWj9ZDzoYEK29waClWjGXv2EGuJWJy3VShmfjkYkNUAsk
Fc7lmfozHCQGvRgz1pB/CIL4YZZDXp+fjn71690DCv5v7qKVIGNSmpit04n6csjU
k6iI2IFFirKpsUcD2da3E1UWv7IZ1zGR1B6SOYXZDPl8b9jKHOI8rHph30Isa7aN
YVdJ3Wfv1FG//JRn/qh+ROV9EgsgWrdYwQKgXgwtpE4Yx1oiLsbnUQq8CWo/ekuM
6FVmGu3S6EBzMM40F21iyBQM8T8nXjuJYMXVlWoyktsXWp3ZjyhjxwtrJZQdskzD
EjdQ2TUYwlrJVw==
X-ME-Sender: <xms:3qCgX_AUN4V0pg_jt9-2hipxSU2d-k4PJeV4wJLaOKy0O3Tu633Kcg>
<xme:3qCgX1imeeok5ZsOlnwHNt87uaz8fbNr5s-ZOs_ibN_SNs6EKy91P77tlEKWaitwr
lYYmBHz4jwflXh5jQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtvddgudejucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg
uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:3qCgX6k7v8GGihFsyx6a-PmgS_Gt4D_yyQuLZ8XgxmdnfHufwe6tVQ>
<xmx:3qCgXxyptSBdWB0w63erlPwSmlY9_mokEF0-BvVjXz03N5-8GMTqPA>
<xmx:3qCgX0TtW43E0OqEd8TmejXgbUZXlJTHnhXnnSowWbZz2sPrY5TXeg>
<xmx:3qCgXzGWU2lZDICciBVZWBX-waxTmMdKdQZhyUDkartAIaaB9VQG5w>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 279F73064674;
Mon, 2 Nov 2020 19:14:21 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, david.marchand@redhat.com,
bruce.richardson@intel.com, olivier.matz@6wind.com,
andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com,
Nikhil Rao <nikhil.rao@intel.com>
Date: Tue, 3 Nov 2020 01:13:52 +0100
Message-Id: <20201103001407.2931963-2-thomas@monjalon.net>
X-Mailer: git-send-email 2.28.0
In-Reply-To: <20201103001407.2931963-1-thomas@monjalon.net>
References: <20201029092751.3837177-1-thomas@monjalon.net>
<20201103001407.2931963-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v3 01/16] eventdev: remove software Rx timestamp
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
This a revert of the commit 569758758dcd ("eventdev: add Rx timestamp").
If the Rx timestamp is not configured on the ethdev port,
there is no reason to set one.
Also the accuracy of the timestamp was bad because set at a late stage.
Anyway there is no trace of the usage of this timestamp.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/prog_guide/event_ethernet_rx_adapter.rst | 6 +-----
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 11 -----------
lib/librte_eventdev/rte_event_eth_rx_adapter.h | 6 +-----
3 files changed, 2 insertions(+), 21 deletions(-)
diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
index 236f43f455..cb44ce0e47 100644
--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
@@ -12,11 +12,7 @@ be supported in hardware or require a software thread to receive packets from
the ethdev port using ethdev poll mode APIs and enqueue these as events to the
event device using the eventdev API. Both transfer mechanisms may be present on
the same platform depending on the particular combination of the ethdev and
-the event device. For SW based packet transfer, if the mbuf does not have a
-timestamp set, the adapter adds a timestamp to the mbuf using
-rte_get_tsc_cycles(), this provides a more accurate timestamp as compared to
-if the application were to set the timestamp since it avoids event device
-schedule latency.
+the event device.
The Event Ethernet Rx Adapter library is intended for the application code to
configure both transfer mechanisms using a common API. A capability API allows
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index f0000d1ede..3c73046551 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -763,7 +763,6 @@ rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_adapter,
uint32_t rss_mask;
uint32_t rss;
int do_rss;
- uint64_t ts;
uint16_t nb_cb;
uint16_t dropped;
@@ -771,16 +770,6 @@ rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_adapter,
rss_mask = ~(((m->ol_flags & PKT_RX_RSS_HASH) != 0) - 1);
do_rss = !rss_mask && !eth_rx_queue_info->flow_id_mask;
- if ((m->ol_flags & PKT_RX_TIMESTAMP) == 0) {
- ts = rte_get_tsc_cycles();
- for (i = 0; i < num; i++) {
- m = mbufs[i];
-
- m->timestamp = ts;
- m->ol_flags |= PKT_RX_TIMESTAMP;
- }
- }
-
for (i = 0; i < num; i++) {
m = mbufs[i];
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
index 2dd259c279..21bb1e54c8 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
@@ -21,11 +21,7 @@
*
* The adapter uses a EAL service core function for SW based packet transfer
* and uses the eventdev PMD functions to configure HW based packet transfer
- * between the ethernet device and the event device. For SW based packet
- * transfer, if the mbuf does not have a timestamp set, the adapter adds a
- * timestamp to the mbuf using rte_get_tsc_cycles(), this provides a more
- * accurate timestamp as compared to if the application were to set the time
- * stamp since it avoids event device schedule latency.
+ * between the ethernet device and the event device.
*
* The ethernet Rx event adapter's functions are:
* - rte_event_eth_rx_adapter_create_ext()
--
2.28.0