From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C43C2A0521; Tue, 3 Nov 2020 11:01:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5C61C848; Tue, 3 Nov 2020 11:01:06 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 75C1EC832 for ; Tue, 3 Nov 2020 11:01:03 +0100 (CET) IronPort-SDR: iMUwUYX/095yTQXXlOj9RhsFSermI0iXe074Q7X17F5lthYkEVe748SOMUWCr9HJIiLEAXRWs/ rW6fQfCuLjMg== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="156016174" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="156016174" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 02:01:00 -0800 IronPort-SDR: 6I4pp4jqJvPxO9Yy1whkZklRGAy7OM3qnPArSkBNoiNfCwukMM3WxqxCWAz7ruVscBwGYNRQly C+ZhduqcRvnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="305753662" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga008.fm.intel.com with ESMTP; 03 Nov 2020 02:00:59 -0800 Received: from sivswdev09.ir.intel.com (sivswdev09.ir.intel.com [10.237.217.48]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 0A3A0xxo015696; Tue, 3 Nov 2020 10:00:59 GMT Received: from sivswdev09.ir.intel.com (localhost [127.0.0.1]) by sivswdev09.ir.intel.com with ESMTP id 0A3A0xra019826; Tue, 3 Nov 2020 10:00:59 GMT Received: (from lma25@localhost) by sivswdev09.ir.intel.com with LOCAL id 0A3A0wUJ019822; Tue, 3 Nov 2020 10:00:58 GMT Date: Tue, 3 Nov 2020 10:00:58 +0000 From: "Liang, Ma" To: Anatoly Burakov Cc: dev@dpdk.org, thomas@monjalon.net, david.hunt@intel.com Message-ID: <20201103100058.GJ29706@sivswdev09.ir.intel.com> References: <57898fa9cf20b6b4a5c101a20874b7098a13edba.1604321851.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57898fa9cf20b6b4a5c101a20874b7098a13edba.1604321851.git.anatoly.burakov@intel.com> Subject: Re: [dpdk-dev] [PATCH] eal: fix incorrect API doc for power intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02 Nov 12:57, Anatoly Burakov wrote: > Currently, the intrinsics documentation refers to `rte_cpu_get_features` > as a check for whether these intrinsics are supported at runtime. This > is incorrect, because actually the user should use the > `rte_cpu_get_intrinsics_support` API to do said check. Fix the typo. > > Fixes: 128021421256 ("eal: add intrinsics support check infrastructure") > Cc: liang.j.ma@intel.com > > Signed-off-by: Anatoly Burakov Acked-by: Liang Ma > --- > lib/librte_eal/include/generic/rte_power_intrinsics.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/include/generic/rte_power_intrinsics.h b/lib/librte_eal/include/generic/rte_power_intrinsics.h > index 9622c7f9ce..dd520d90fa 100644 > --- a/lib/librte_eal/include/generic/rte_power_intrinsics.h > +++ b/lib/librte_eal/include/generic/rte_power_intrinsics.h > @@ -33,7 +33,7 @@ > * optimized power state may be aborted. > * > * @warning It is responsibility of the user to check if this function is > - * supported at runtime using `rte_cpu_get_features()` API call. > + * supported at runtime using `rte_cpu_get_intrinsics_support()` API call. > * Failing to do so may result in an illegal CPU instruction error. > * > * @param p > @@ -74,7 +74,7 @@ static inline void rte_power_monitor(const volatile void *p, > * waking up the CPU. > * > * @warning It is responsibility of the user to check if this function is > - * supported at runtime using `rte_cpu_get_features()` API call. > + * supported at runtime using `rte_cpu_get_intrinsics_support()` API call. > * Failing to do so may result in an illegal CPU instruction error. > * > * @param p > @@ -110,7 +110,7 @@ static inline void rte_power_monitor_sync(const volatile void *p, > * timestamp is reached. > * > * @warning It is responsibility of the user to check if this function is > - * supported at runtime using `rte_cpu_get_features()` API call. > + * supported at runtime using `rte_cpu_get_intrinsics_support()` API call. > * Failing to do so may result in an illegal CPU instruction error. > * > * @param tsc_timestamp > -- > 2.17.1