DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Leyi Rong <leyi.rong@intel.com>
Cc: qi.z.zhang@intel.com, ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC
Date: Tue, 3 Nov 2020 14:44:00 +0000	[thread overview]
Message-ID: <20201103144400.GF1144@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201103135200.41166-3-leyi.rong@intel.com>

On Tue, Nov 03, 2020 at 09:52:00PM +0800, Leyi Rong wrote:
> Fix the build error when -march=skylake-avx512 is not supported on
> lower version GCC.
> 
> Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx")
> 
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> ---
>  drivers/net/iavf/meson.build | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build
> index e257f5a6e1..099b6a725d 100644
> --- a/drivers/net/iavf/meson.build
> +++ b/drivers/net/iavf/meson.build
> @@ -46,12 +46,16 @@ if arch_subdir == 'x86'
>  
>  	if iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true
>  		cflags += ['-DCC_AVX512_SUPPORT']
> +		avx512_args = [cflags, '-mavx512f', '-mavx512bw']
> +		if cc.has_argument('-march=skylake-avx512')
> +			avx512_args += '-march=skylake-avx512'
> +		endif
>  		iavf_avx512_lib = static_library('iavf_avx512_lib',
>  				'iavf_rxtx_vec_avx512.c',
>  				dependencies: [static_rte_ethdev,
> -					static_rte_kvargs, static_rte_hash],
> +				static_rte_kvargs, static_rte_hash],

This is an unnecesary whitespace change that can be dropped from the patch,
and doesn't actually clean things up, since the extra indent is useful to
show the continuation of the array.

>  				include_directories: includes,
> -				c_args: [cflags, '-mavx512f', '-mavx512bw', '-march=skylake-avx512'])
> +				c_args: avx512_args)
>  		objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c')
>  	endif
>  endif
> -- 

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2020-11-03 14:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 12:56 [dpdk-dev] [PATCH 0/2] " Leyi Rong
2020-11-03 12:56 ` [dpdk-dev] [PATCH 1/2] net/ice: " Leyi Rong
2020-11-03 13:28   ` Bruce Richardson
2020-11-03 14:13     ` Rong, Leyi
2020-11-03 12:56 ` [dpdk-dev] [PATCH 2/2] net/iavf: " Leyi Rong
2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong
2020-11-03 13:51   ` [dpdk-dev] [PATCH v2 1/2] net/ice: " Leyi Rong
2020-11-03 14:42     ` Bruce Richardson
2020-11-03 15:29       ` Ferruh Yigit
2020-11-03 15:37         ` Ferruh Yigit
2020-11-03 15:42           ` Ali Alnubani
2020-11-03 15:57             ` Ferruh Yigit
2020-11-03 13:52   ` [dpdk-dev] [PATCH v2 2/2] net/iavf: " Leyi Rong
2020-11-03 14:44     ` Bruce Richardson [this message]
2020-11-03 15:28       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103144400.GF1144@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=leyi.rong@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).