From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9352BA0521; Tue, 3 Nov 2020 15:44:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73415CB63; Tue, 3 Nov 2020 15:44:10 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5A800CAD4 for ; Tue, 3 Nov 2020 15:44:06 +0100 (CET) IronPort-SDR: mi0L8zWr6Y18zPxHJrw5uPZw644USa/p6vQBr+khiaFJDOxm7RGgZLveyg4n4aoAeeerqU+PTc uAG+H8/Npbew== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="165557409" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="165557409" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 06:44:05 -0800 IronPort-SDR: pCZZ+r0MNGMtFfS/AEuHYVMWrixZAJ5qG6vK2eEirM6DRPFLoYrX6VPjZrbFhb9o8yo4sKFpq4 etH0f2AumYAQ== X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="538512782" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.45.202]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 03 Nov 2020 06:44:04 -0800 Date: Tue, 3 Nov 2020 14:44:00 +0000 From: Bruce Richardson To: Leyi Rong Cc: qi.z.zhang@intel.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20201103144400.GF1144@bricha3-MOBL.ger.corp.intel.com> References: <20201103125629.56030-1-leyi.rong@intel.com> <20201103135200.41166-1-leyi.rong@intel.com> <20201103135200.41166-3-leyi.rong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103135200.41166-3-leyi.rong@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 03, 2020 at 09:52:00PM +0800, Leyi Rong wrote: > Fix the build error when -march=skylake-avx512 is not supported on > lower version GCC. > > Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") > > Signed-off-by: Leyi Rong > --- > drivers/net/iavf/meson.build | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build > index e257f5a6e1..099b6a725d 100644 > --- a/drivers/net/iavf/meson.build > +++ b/drivers/net/iavf/meson.build > @@ -46,12 +46,16 @@ if arch_subdir == 'x86' > > if iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true > cflags += ['-DCC_AVX512_SUPPORT'] > + avx512_args = [cflags, '-mavx512f', '-mavx512bw'] > + if cc.has_argument('-march=skylake-avx512') > + avx512_args += '-march=skylake-avx512' > + endif > iavf_avx512_lib = static_library('iavf_avx512_lib', > 'iavf_rxtx_vec_avx512.c', > dependencies: [static_rte_ethdev, > - static_rte_kvargs, static_rte_hash], > + static_rte_kvargs, static_rte_hash], This is an unnecesary whitespace change that can be dropped from the patch, and doesn't actually clean things up, since the extra indent is useful to show the continuation of the array. > include_directories: includes, > - c_args: [cflags, '-mavx512f', '-mavx512bw', '-march=skylake-avx512']) > + c_args: avx512_args) > objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c') > endif > endif > -- Acked-by: Bruce Richardson