From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30A0DA0521; Tue, 3 Nov 2020 15:48:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96FBACB00; Tue, 3 Nov 2020 15:48:48 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 9D7BACAD4 for ; Tue, 3 Nov 2020 15:48:46 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A3EkGvC001240; Tue, 3 Nov 2020 06:48:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0220; bh=D//bKP1TAppwRbmhTNWErNQ3FcuqyKIM5VaDyKTHD6U=; b=PGNicD2iH5U8LS788/yojq/VKvsGoXdixy3+d6f2eqsrFdk1NndBgs762dYdrM4hoxKO pa7pupkjmE1gVui466YAZucU8hPvqGiWAZRSoY8jXmRqRrV9FGS1L0KMpRyOP2FSWS/z 6Jn4seFnE/mxiXFhER1CpyZPJm1Ryvbc8h06kwd0xCqUifnyhZ88bQAAKECDk+H8EXFz 1tDbvjSIpLdwlnCxvDNK9r4I6yyB7Ni52CyI31bo0wr0sPiw1zzX3QKgrxuVJgeE4RMl sfEQBN5WxDhpidL1F1mUHvkaQlCObbLjBah8cbZyqTRIY+lIhgCR4ZhX9pKaJpwn0WtD oA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 34h7enwbsy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 03 Nov 2020 06:48:44 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 3 Nov 2020 06:48:41 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 3 Nov 2020 06:48:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KdHPvj5XJDsHHOxD2gyBhhZSZtcYCVaMbGKycVK2Egdpe2Gn1OiJjbl8A7E0ef5YMHh9Y8bNnNhRpkvnPiV+lsZPcicghvI/1XmHUz0BPrf7S2muHKbqxpmouq9aN9K1mrkRwYHhi+azam7w8My1JWn5SKEytp+BIOUwIAPyF0GA7bcX6/OCfIMXIfngE/zXIFUNN4eUbHXSUOVWvtcv0URbtD68UXsTgH2W65+aiwCSNkXF+nuKJvdlRM/xkpZq9BH+WVZobDt3fioC4elgv33Can8W4o+Dok+eGL4UYPLtxNurVl/UO4cAz6SsJhsNeLc1ruWQUuSd02MlK+7lUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D//bKP1TAppwRbmhTNWErNQ3FcuqyKIM5VaDyKTHD6U=; b=VtP4PzKFL/NxLZz8WRaeqVv8jIwGZM8H9uBIiFWknrnsfgLzGA4aNca4CYEAx2OAdGH4v7KlzLB5Dubj3wHWznZm6/wDqRBfb/hBfj+6F1VLniMOChyCf3d5AgFbeOZT1a6YxO3HKR5JlGWYYCstZil3mML36Ba/z9ac6zZXdftaZkHWd8hXbvRrJXdbqyIW7VAwU6gE6vd57jp+VZm5zJPUr1XAOsYucagvjsVcZHzKXcEgeofBhIA+/LaGcq4WwE/p6MNvLiYI06yg3dd8AytHVo3j6OwjeoRHm5xlVieoLECaapKfZLgs3hDVbOIEKCodlowHDL7NmiGXPxd2PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D//bKP1TAppwRbmhTNWErNQ3FcuqyKIM5VaDyKTHD6U=; b=EveHvJHf6OdwPRb1giLB7F//GBCEMPvPsHUnxGjh3kKEXZvYFx2vF+fgIj4wQzQfFNrkVuPRql1QX/hhGgwI1OMpy7ZwiH14X5fmHg9gp3X4m3ABrQbSUQFMC8l3NsiTt3nrFlTMt5otBozbXFgakp3KiMb5i8ZogDPQbiJX4Ns= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=marvell.com; Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW2PR18MB2170.namprd18.prod.outlook.com (2603:10b6:907:2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19; Tue, 3 Nov 2020 14:48:40 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::b960:6770:a1:2a19%7]) with mapi id 15.20.3499.032; Tue, 3 Nov 2020 14:48:40 +0000 Date: Tue, 3 Nov 2020 20:18:23 +0530 From: Harman Kalra To: Thomas Monjalon , CC: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , , , Message-ID: <20201103144746.GA176496@outlook.office365.com> References: <20201103141640.174043-1-hkalra@marvell.com> <4848304.ISYM4h8o7B@thomas> <18233106.h1nHT6NZqv@thomas> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18233106.h1nHT6NZqv@thomas> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: BM1PR0101CA0007.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::17) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (1.6.215.26) by BM1PR0101CA0007.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Tue, 3 Nov 2020 14:48:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c43e6c6e-2e60-42a1-02f4-08d880078d9b X-MS-TrafficTypeDiagnostic: MW2PR18MB2170: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cpWUmompr6Lheodu+lJ2wgFV2AJl3vcZEVZh+Yi4nkdHE9eUjlDasPE6WFq/N46QcEgRgAJLbBpmW7iRMfl7xRl0H7BbIdHG5q1Kk7d1xmr/2kuibXgEC3a/6YQVMIwbSmsbOVtei9wFVZKhMXUbKuKXkrjOyB156BCUlz3+7cRoJ9wclcEyxluB/Y7cwFRvl14WJkQNK1k1xiiVrxHK7hl1GO4QZpbTsIHCnKSTASJzhXfFg5vzsQ7UxDofokd0fJ7qwtp0N6eCEQvh5fBBbyF1NlRxLiaZisO7qtahWraZUb/Pqmx4CQJgDhmwSxptZaOGwRK9DjB6Hovh+0/d7h0eqaNSnFjziMFP3qbV1nQPc61Yb1Q9z+u9GzemlTBHiYIqc4Bgqn227X+RBENWC/jOZVTF9V1JG7a5U/r3A3rE4RuLd56FYd/qsdKagGhgl5U5aPNBj1byz42vS/+W7lVTOlLjdjMeBKW9XoYdjWoxrLENXEZZKK98XEPXaXMO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(54906003)(6506007)(8936002)(7696005)(34580700001)(52116002)(33656002)(316002)(4326008)(55016002)(83380400001)(9686003)(8676002)(66476007)(1076003)(66556008)(186003)(6666004)(1006002)(16526019)(478600001)(86362001)(966005)(26005)(5660300002)(956004)(2906002)(66946007)(36456003)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: q0lATHmxwZ/Rvk2Cr+AgKf6O+NGeXzY5BOge2DNBHwvC/IR/Lso4aeN1u9lC+C9yBfS7QODJDy+MuptaAt3CdjBP63Ew6Z8TDt0HDjtBQUeNU5mMryi4nrIhV0u96o1WZTMQlrrAqdrntoM7VTZ27sbU9z9lfwj9pVsUQKzAIiVMGofvS3b4y2gHKlkp0SjTviiPMw73uLKQV9OJZUfmWY8aP2/xIgyrMgRbJXV1z7PO5X2CwGDrB7Jd8toiGamOin80BoM8w/FElnmuz85E3AVF4uh2gpqf8guyZpMOEyy5lO6va5cadUxsHVM3FzS2khmjvpZrJRzpYbTf+mqe1EgbzE0lAfz2bjS5QPq2xpW0mCVuJQpKXGt3616JMAIrP69JuLk6fxL34tPYILtj5/HDKiOur04uQ4hv/BWjNU4Ai8YV0MwxwsCOw0CFo691rsPc+Ko6jxZ3P0pDG/Zmw9yOLjIjlDYUREFroTKXJoMqdz4xJ/15jwdtXxmeCeo4Hgv7TC+CK1ELFItZJOjFS4gy+28g/1ZC/MJiE5jr5cp41tIPlU+XVamJbfceiE28Sk1gSzzg52O64fUQhGsT9/xU0NoaqYijJZ4AErlz0oTPg5TV1PUW986C2AM4rxwx7jFsYxf9wQQkNqg/LQwagw== X-MS-Exchange-CrossTenant-Network-Message-Id: c43e6c6e-2e60-42a1-02f4-08d880078d9b X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 14:48:40.3470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jr2L5LVRDvoB/vTqW9tcsOyxR/0/mQjIFL9fM+6yi20nsWBAm+LQm2edXBPWzPPusz4Viyre5AGf4UNn0kOPsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2170 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-03_08:2020-11-03, 2020-11-03 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] net/octeontx2: register dynamic mbuf timestamp field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 03, 2020 at 03:26:17PM +0100, Thomas Monjalon wrote: > External Email > > ---------------------------------------------------------------------- > +Cc David and Olivier to make them laugh or cry. > > 03/11/2020 15:24, Thomas Monjalon: > > 03/11/2020 15:16, Harman Kalra: > > > A crash is observed if dynamic mbuf timestamp field is > > > registered in dev_start, as in most of the applications > > > rte_eth_timesync_enable is called after dev_start due > > > to which timestamp field did not get registered. > > > > So you are not reading your emails? > > > > I was waiting for you, so I looked at the ugly code of octeontx2 > > with Olivier and David, and we fixed it already. > > > > Not reading emails is wasting time of everybody. > > On the contrary, being available on IRC can speed up work. > > My focus was to fix the issue ASAP to meet the deadline as well as well making sure that our performance nos are also not hampered with the change. By no means its a ugly code, its properly designed to cover many use cases. While the changes done as part of v5 are partially correct becasue if our kernel changes wrt PTP fails then its a unecessary registration. https://patches.dpdk.org/patch/83600/ Thats why my patch does the registration only if kernel changes are successful. > > > > > Signed-off-by: Harman Kalra > > > --- a/drivers/net/octeontx2/otx2_ethdev.c > > > +++ b/drivers/net/octeontx2/otx2_ethdev.c > > > @@ -2219,16 +2219,6 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev) > > > else > > > otx2_nix_timesync_disable(eth_dev); > > > > > > - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_TSTAMP_F) { > > > - rc = rte_mbuf_dyn_rx_timestamp_register( > > > - &dev->tstamp.tstamp_dynfield_offset, > > > - &dev->tstamp.rx_tstamp_dynflag); > > > - if (rc != 0) { > > > - otx2_err("Failed to register Rx timestamp field/flag"); > > > - return -rte_errno; > > > - } > > > - } > > > - > > > > This is wrong, you still need to register for the case > > of DEV_RX_OFFLOAD_TIMESTAMP without timesync. > > > > In my v5, it is moved below after VF special config. > > > > > /* Update VF about data off shifted by 8 bytes if PTP already > > > * enabled in PF owning this VF > > > */ > > > > > > >